-
Notifications
You must be signed in to change notification settings - Fork 461
feat: add recent document api support. #3131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
Package Changes Through 6af4a72There are 17 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, localhost with patch, barcode-scanner with patch, barcode-scanner-js with patch, http with patch, http-js with patch, nfc with patch, nfc-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor, websocket with patch, websocket-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Didn't quite try it yet, just some early feedbacks from first glance
We'll also want to add this to the CI
https://github.com/tauri-apps/plugins-workspace/blob/v2/.github/workflows/test-rust.yml
| // SPDX-License-Identifier: Apache-2.0 | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| const COMMANDS: &[&str] = &["execute"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const COMMANDS: &[&str] = &["execute"]; | |
| const COMMANDS: &[&str] = &["add_recent_document", "get_recent_documents", "clear_recent_documents"]; |
| @@ -0,0 +1,13 @@ | |||
| # Automatically generated - DO NOT EDIT! | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this after changing the commands in build.rs
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "@tauri-apps/plugin-PLUGIN_NAME", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "@tauri-apps/plugin-PLUGIN_NAME", | |
| "name": "@tauri-apps/plugin-recent-doc", |
| objc2 = "0.6.0" | ||
|
|
||
| [target."cfg(target_os = \"windows\")".dependencies] | ||
| windows = { version = "0.62.2", features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| windows = { version = "0.62.2", features = [ | |
| windows = { version = "0.61", features = [ |
We need to use 0.61 here for the lower rust version requirement to support Windows 7 in tauri v2
| use std::os::windows::ffi::{OsStrExt, OsStringExt}; | ||
| use windows::{core::*, Win32::Foundation::*, Win32::System::Com::*, Win32::UI::Shell::*}; | ||
| unsafe { | ||
| let path_wide: Vec<u16> = OsStr::new(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use HSTRING here instead of doing it manually
add recent documents api support for issue tauri-apps/tauri#14460
now only available for macos and windows