Skip to content

Commit ce7b4af

Browse files
committed
minor #180 Remove some unused props (dunglas, weaverryan)
This PR was squashed before being merged into the 1.0-dev branch (closes #180). Discussion ---------- Remove some unused props Commits ------- e6c940f Remove some unused props
2 parents f139ada + e6c940f commit ce7b4af

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

src/Doctrine/EntityRegenerator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ final class EntityRegenerator
3030
private $generator;
3131
private $overwrite;
3232

33-
public function __construct(DoctrineHelper $doctrineHelper, FileManager $fileManager, Generator $generator, string $projectDirectory, bool $overwrite)
33+
public function __construct(DoctrineHelper $doctrineHelper, FileManager $fileManager, Generator $generator, bool $overwrite)
3434
{
3535
$this->doctrineHelper = $doctrineHelper;
3636
$this->fileManager = $fileManager;

src/Maker/MakeController.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Doctrine\Common\Annotations\Annotation;
1515
use Symfony\Bundle\MakerBundle\ConsoleStyle;
1616
use Symfony\Bundle\MakerBundle\DependencyBuilder;
17-
use Symfony\Bundle\MakerBundle\FileManager;
1817
use Symfony\Bundle\MakerBundle\Generator;
1918
use Symfony\Bundle\MakerBundle\InputConfiguration;
2019
use Symfony\Bundle\MakerBundle\Str;
@@ -29,13 +28,6 @@
2928
*/
3029
final class MakeController extends AbstractMaker
3130
{
32-
private $fileManager;
33-
34-
public function __construct(FileManager $fileManager)
35-
{
36-
$this->fileManager = $fileManager;
37-
}
38-
3931
public static function getCommandName(): string
4032
{
4133
return 'make:controller';

src/Maker/MakeEntity.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,13 @@ final class MakeEntity extends AbstractMaker implements InputAwareMakerInterface
4646
{
4747
private $fileManager;
4848
private $doctrineHelper;
49-
private $projectDirectory;
5049
private $generator;
5150

5251
public function __construct(FileManager $fileManager, string $projectDirectory, DoctrineHelper $doctrineHelper, Generator $generator = null)
5352
{
5453
$this->fileManager = $fileManager;
55-
$this->projectDirectory = $projectDirectory;
5654
$this->doctrineHelper = $doctrineHelper;
55+
// $projectDirectory is unused, argument kept for BC
5756

5857
if (null === $generator) {
5958
@trigger_error(sprintf('Passing a "%s" instance as 4th argument is mandatory since version 1.5.', Generator::class), E_USER_DEPRECATED);
@@ -808,7 +807,7 @@ private function isClassInVendor(string $class): bool
808807

809808
private function regenerateEntities(string $classOrNamespace, bool $overwrite, Generator $generator)
810809
{
811-
$regenerator = new EntityRegenerator($this->doctrineHelper, $this->fileManager, $generator, $this->projectDirectory, $overwrite);
810+
$regenerator = new EntityRegenerator($this->doctrineHelper, $this->fileManager, $generator, $overwrite);
812811
$regenerator->regenerateEntities($classOrNamespace);
813812
}
814813

0 commit comments

Comments
 (0)