[make:registration] Make router optional in MakeRegistrationForm constructor (#1227)

Author: odolbeau

src/Maker/MakeRegistrationForm.php

@@ -85,8 +85,8 @@ final class MakeRegistrationForm extends AbstractMaker
     public function __construct(
         private FileManager $fileManager,
         private FormTypeRenderer $formTypeRenderer,
-        private RouterInterface $router,
         private DoctrineHelper $doctrineHelper,
+        private ?RouterInterface $router = null,
     ) {
     }
 
@@ -111,6 +111,10 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
     {
         $interactiveSecurityHelper = new InteractiveSecurityHelper();
 
+        if (null === $this->router) {
+            throw new RuntimeCommandException('Router have been explicitely disabled in your configuration. This command needs to use the router.');
+        }
+
         if (!$this->fileManager->fileExists($path = 'config/packages/security.yaml')) {
             throw new RuntimeCommandException('The file "config/packages/security.yaml" does not exist. This command needs that file to accurately build your registration form.');
         }

src/Resources/config/makers.xml

@@ -77,8 +77,8 @@
             <service id="maker.maker.make_registration_form" class="Symfony\Bundle\MakerBundle\Maker\MakeRegistrationForm">
                 <argument type="service" id="maker.file_manager" />
                 <argument type="service" id="maker.renderer.form_type_renderer" />
-                <argument type="service" id="router" />
                 <argument type="service" id="maker.doctrine_helper" />
+                <argument type="service" id="router" on-invalid="ignore" />
                 <tag name="maker.command" />
             </service>