feature #105 Added a maker to generate empty fixture classes (javiereguiluz, weaverryan)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Added a maker to generate empty fixture classes

This fixes #84 following the new best practices recommended for Doctrine fixtures (https://symfony.com/doc/master/bundles/DoctrineFixturesBundle/index.html).

Commits
-------

32cbedb no space
e4efd5b tweak
6ecad09 fixtures -> fixtures
359c44d Minor tweaks to make:fixtures
35d79e4 Adding missing use
b9b731c Added an argument to set the fixtures class name
ec5dffc Fixed issues
cbe6573 Added the missing command help
66fb43d Added a maker to generate empty fixture classes

Author: weaverryan

src/Maker/MakeFixtures.php

@@ -0,0 +1,84 @@
+<?php
+
+/*
+ * This file is part of the Symfony MakerBundle package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Maker;
+
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\ORM\Mapping\Column;
+use Symfony\Bundle\MakerBundle\ConsoleStyle;
+use Symfony\Bundle\MakerBundle\DependencyBuilder;
+use Symfony\Bundle\MakerBundle\InputConfiguration;
+use Symfony\Bundle\MakerBundle\Str;
+use Symfony\Bundle\MakerBundle\Validator;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+
+/**
+ * @author Javier Eguiluz <[email protected]>
+ * @author Ryan Weaver <[email protected]>
+ */
+final class MakeFixtures extends AbstractMaker
+{
+    public static function getCommandName(): string
+    {
+        return 'make:fixtures';
+    }
+
+    public function configureCommand(Command $command, InputConfiguration $inputConf)
+    {
+        $command
+            ->setDescription('Creates a new class to load Doctrine fixtures')
+            ->addArgument('fixtures-class', InputArgument::OPTIONAL, 'The class name of the fixtures to create (e.g. <fg=yellow>AppFixtures</>)')
+            ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeFixture.txt'))
+        ;
+    }
+
+    public function getParameters(InputInterface $input): array
+    {
+        $fixturesClassName = Str::asClassName($input->getArgument('fixtures-class'));
+        Validator::validateClassName($fixturesClassName);
+
+        return [
+            'fixtures_class_name' => $fixturesClassName,
+        ];
+    }
+
+    public function getFiles(array $params): array
+    {
+        return [
+            __DIR__.'/../Resources/skeleton/doctrine/Fixtures.tpl.php' => 'src/DataFixtures/'.$params['fixtures_class_name'].'.php',
+        ];
+    }
+
+    public function writeSuccessMessage(array $params, ConsoleStyle $io)
+    {
+        parent::writeSuccessMessage($params, $io);
+
+        $io->text([
+            'Next: Open your new fixtures class and start customizing it.',
+            sprintf('Load your fixtures by running: <comment>php %s doctrine:fixtures:load</comment>', $_SERVER['PHP_SELF']),
+            'Docs: <fg=yellow>https://symfony.com/doc/master/bundles/DoctrineFixturesBundle/index.html</>',
+        ]);
+    }
+
+    public function configureDependencies(DependencyBuilder $dependencies)
+    {
+        $dependencies->addClassDependency(
+            Column::class,
+            'doctrine'
+        );
+        $dependencies->addClassDependency(
+            Fixture::class,
+            'orm-fixtures'
+        );
+    }
+}

src/Resources/config/makers.xml

@@ -25,6 +25,10 @@
                 <tag name="maker.command" />
             </service>
 
+            <service id="maker.maker.make_fixtures" class="Symfony\Bundle\MakerBundle\Maker\MakeFixtures">
+                <tag name="maker.command" />
+            </service>
+
             <service id="maker.maker.make_form" class="Symfony\Bundle\MakerBundle\Maker\MakeForm">
                 <tag name="maker.command" />
             </service>

src/Resources/help/MakeFixture.txt

@@ -0,0 +1,5 @@
+The <info>%command.name%</info> command generates a new Doctrine fixtures class.
+
+<info>php %command.full_name% AppFixtures</info>
+
+If the argument is missing, the command will ask for a class interactively.

src/Resources/skeleton/doctrine/Fixtures.tpl.php

@@ -0,0 +1,17 @@
+<?= "<?php\n" ?>
+
+namespace App\DataFixtures;
+
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\Common\Persistence\ObjectManager;
+
+class <?= $fixtures_class_name ?> extends Fixture
+{
+    public function load(ObjectManager $manager)
+    {
+        // $product = new Product();
+        // $manager->persist($product);
+
+        $manager->flush();
+    }
+}

tests/Maker/FunctionalTest.php

@@ -12,6 +12,7 @@
 use Symfony\Bundle\MakerBundle\Maker\MakeCommand;
 use Symfony\Bundle\MakerBundle\Maker\MakeController;
 use Symfony\Bundle\MakerBundle\Maker\MakeEntity;
+use Symfony\Bundle\MakerBundle\Maker\MakeFixtures;
 use Symfony\Bundle\MakerBundle\Maker\MakeForm;
 use Symfony\Bundle\MakerBundle\Maker\MakeFunctionalTest;
 use Symfony\Bundle\MakerBundle\Maker\MakeMigration;
@@ -111,6 +112,16 @@ public function getCommandTests()
             ->addPostMakeCommand('./bin/console doctrine:schema:create --env=test')
         ];
 
+        yield 'fixtures' => [MakerTestDetails::createTest(
+            $this->getMakerInstance(MakeFixtures::class),
+            [
+                'AppFixtures'
+            ])
+            ->assert(function(string $output, string $directory) {
+                $this->assertContains('created: src/DataFixtures/AppFixtures.php', $output);
+            })
+        ];
+
         yield 'form' => [MakerTestDetails::createTest(
             $this->getMakerInstance(MakeForm::class),
             [