minor #122 Using a Twig CS tool to verify our generated Twig code (weaverryan)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Using a Twig CS tool to verify our generated Twig code

A simple way to help make sure we generate decent code - it will help #113, which has a few violations ;).

Commits
-------

2214434 Using a Twig CS tool to verify our generated Twig code

Author: weaverryan

composer.json

@@ -21,6 +21,7 @@
         "symfony/http-kernel": "^3.4|^4.0"
     },
     "require-dev": {
+        "allocine/twigcs": "^3.0",
         "friendsofphp/php-cs-fixer": "^2.8",
         "symfony/phpunit-bridge": "^3.4|^4.0",
         "symfony/process": "^3.4|^4.0"

src/Test/MakerTestCase.php

@@ -92,7 +92,7 @@ protected function executeMakerCommand(MakerTestDetails $testDetails)
             throw new \Exception(sprintf('Running maker command failed: "%s" "%s"', $makerProcess->getOutput(), $makerProcess->getErrorOutput()));
         }
 
-        $files = $this->getGeneratedPhpFilesFromOutputText($makerProcess->getOutput());
+        $files = $this->getGeneratedFilesFromOutputText($makerProcess->getOutput(), '.php');
         foreach ($files as $file) {
             $process = $this->createProcess(
                 sprintf(
@@ -106,6 +106,19 @@ protected function executeMakerCommand(MakerTestDetails $testDetails)
             $this->assertTrue($process->isSuccessful(), sprintf('File "%s" has a php-cs problem: %s', $file, $process->getOutput()));
         }
 
+        $files = $this->getGeneratedFilesFromOutputText($makerProcess->getOutput(), '.twig');
+        foreach ($files as $file) {
+            $process = $this->createProcess(
+                sprintf(
+                    'php vendor/bin/twigcs lint %s',
+                    self::$currentRootDir.'/'.$file
+                ),
+                __DIR__.'/../../'
+            );
+            $process->run();
+            $this->assertTrue($process->isSuccessful(), sprintf('File "%s" has a php-cs problem: %s', $file, $process->getOutput()));
+        }
+
         foreach ($testDetails->getPostMakeCommands() as $postCommand) {
             $process = $this->createProcess($postCommand, self::$currentRootDir);
             $process->run();
@@ -165,7 +178,7 @@ private function buildFlexProject()
         $this->runProcess($process);
     }
 
-    private function getGeneratedPhpFilesFromOutputText($output)
+    private function getGeneratedFilesFromOutputText($output, $fileExtension)
     {
         $files = [];
         foreach (explode("\n", $output) as $line) {
@@ -174,7 +187,10 @@ private function getGeneratedPhpFilesFromOutputText($output)
             }
 
             list(, $filename) = explode(':', $line);
-            $files[] = trim($filename);
+            $filename = trim($filename);
+            if ($fileExtension === substr($filename, (-1 * strlen($fileExtension)))) {
+                $files[] = trim($filename);
+            }
         }
 
         return $files;