Commit 47c9093
committed
bug #587 change from-email-address default value to empty string (IndraGunawan)
This PR was squashed before being merged into the 1.0-dev branch.
Discussion
----------
change from-email-address default value to empty string
when create a reset-password at question `What email address will be used to send reset confirmations? e.g. [email protected]` and we just enter without filling the answer it will thrown an exception
```
Argument 1 passed to Symfony\Bundle\MakerBundle\Validator::validateEmailAddress() must be of the type string, null given, called in /path/vendor/symfony/console/Helper/QuestionHelper.php on line 468
```
there are 2 possible solution. 1. change the default value to empty string (this PR), or 2. make the `validateEmailAddress` argument nullable and check the value inside the method.
Commits
-------
698f566 change from-email-address default value to empty string2 files changed
+8
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
| 170 | + | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
71 | 72 | | |
| 73 | + | |
| 74 | + | |
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
75 | 82 | | |
76 | 83 | | |
77 | 84 | | |
| |||
0 commit comments