Replies: 1 comment
-
|
No major changes are done. Moved injections outside of constructor. See this line |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello. I didn't want to make an issue for this but thought I should post about it.
My team was using the CookieService and had V20.1.0. We recently updated to V20.1.1 and it introduced breaking changes, which was unexpected with a patch version update. We were extending the CookieService and passing in the document and platformId to the constructor, and with the update we had to change our code to no longer do that. Not a big deal, so I didn't want to make an issue or bug, but figured I should point it out. Here's how our constructor had to change for our cookie token service class that extends your CookieService.
Our old constructor:
constructor(
windowProvider: WindowService,
@Inject(PLATFORM_ID) platformId: InjectionToken,
)
{
super(windowProvider.document, platformId);
}
Our new constructor:
constructor() {
super();
}
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions