fix(be): remove unused auth method

Author: fiftin

api/auth_verify.go

@@ -112,33 +112,3 @@ func sendEmailVerificationCode(code string, email string) error {
 
 	return err
 }
-
-func startEmailVerification(w http.ResponseWriter, r *http.Request) {
-	if !util.Config.Auth.Email.Enabled {
-		helpers.WriteErrorStatus(w, "EMAIL_VERIFICATION_DISABLED", http.StatusForbidden)
-		return
-	}
-
-	session, ok := getSession(r)
-
-	if !ok {
-		w.WriteHeader(http.StatusUnauthorized)
-		return
-	}
-
-	store := helpers.Store(r)
-
-	user, err := store.GetUser(session.UserID)
-	if err != nil {
-		helpers.WriteError(w, err)
-		return
-	}
-
-	code := util.RandString(16)
-
-	err = sendEmailVerificationCode(code, user.Email)
-	if err != nil {
-		helpers.WriteError(w, err)
-		return
-	}
-}

api/login_email.go

@@ -1,12 +1,12 @@
 package api
 
 import (
-	"errors"
+	"net/http"
+
 	"github.com/semaphoreui/semaphore/api/helpers"
 	"github.com/semaphoreui/semaphore/db"
 	"github.com/semaphoreui/semaphore/pkg/random"
 	log "github.com/sirupsen/logrus"
-	"net/http"
 )
 
 func newEmailOtp(userID int, userEmail string, store db.Store) error {
@@ -46,47 +46,3 @@ func resendEmailOtp(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 }
-
-func loginEmail(w http.ResponseWriter, r *http.Request) {
-
-	var email struct {
-		Email string `json:"email" binding:"required"`
-	}
-	if !helpers.Bind(w, r, &email) {
-		return
-	}
-
-	store := helpers.Store(r)
-
-	user, err := store.GetUserByLoginOrEmail("", email.Email)
-
-	if err != nil {
-		if errors.Is(err, db.ErrNotFound) {
-			user, err = store.CreateUserWithoutPassword(db.User{
-				Email:    email.Email,
-				External: true,
-				Alert:    true,
-				Pro:      true,
-				Name:     getRandomProfileName(),
-				Username: getRandomUsername(),
-			})
-		} else {
-			var validationError *db.ValidationError
-			switch {
-			case errors.As(err, &validationError):
-				// TODO: Return more informative error code.
-			}
-
-			log.WithError(err).WithFields(log.Fields{
-				"email":   email.Email,
-				"context": "loginEmail",
-			}).Error("Failed to get or create user by email")
-			w.WriteHeader(http.StatusInternalServerError)
-			return
-		}
-	}
-
-	createSession(w, r, user, false)
-
-	w.WriteHeader(http.StatusNoContent)
-}

api/router.go

@@ -144,8 +144,6 @@ func Route(
 	publicAPIRouter.Use(StoreMiddleware, JSONMiddleware)
 
 	publicAPIRouter.HandleFunc("/auth/login", login).Methods("GET", "POST")
-	publicAPIRouter.HandleFunc("/auth/verify/email", startEmailVerification).Methods("POST")
-	publicAPIRouter.HandleFunc("/auth/login/email", loginEmail).Methods("GET", "POST")
 	publicAPIRouter.HandleFunc("/auth/login/email/resend", resendEmailOtp).Methods("GET", "POST")
 	publicAPIRouter.HandleFunc("/auth/verify", verifySession).Methods("POST")
 	publicAPIRouter.HandleFunc("/auth/recovery", recoverySession).Methods("POST")

web/src/views/Auth.vue

@@ -224,48 +224,13 @@
                   {{ $t('signIn') }}
                 </v-btn>
 
-              </div>
+                <div
+                  class="auth__divider"
+                  v-if="oidcProviders.length > 0"
+                >or</div>
 
-              <div v-else>
-                <v-text-field
-                  v-model="email"
-                  :label="$t('Email')"
-                  :rules="[v => !!v || $t('email_required')]"
-                  type="email"
-                  required
-                  :disabled="signInProcess"
-                  @keyup.enter.native="signInWithEmail"
-                  style="margin-bottom: 20px;"
-                  data-testid="auth-password"
-                  outlined
-                  class="mb-0"
-                ></v-text-field>
-
-                <v-btn
-                  large
-                  color="primary"
-                  @click="signInWithEmail"
-                  :disabled="signInProcess"
-                  block
-                  rounded
-                  data-testid="auth-signin-with-eamil"
-                >
-                  <v-icon
-                    left
-                    dark
-                  >
-                    mdi-email
-                  </v-icon>
-
-                  {{ $t('Continue with Email') }}
-                </v-btn>
               </div>
 
-              <div
-                class="auth__divider"
-                v-if="oidcProviders.length > 0"
-              >or</div>
-
               <v-btn
                 large
                 v-for="provider in oidcProviders"