Skip to content

Commit 7881365

Browse files
authored
Merge pull request #1029 from akinomyoga/fixup-api-renaming
refactor: adjust API/naming of generators
2 parents 84921b8 + 1168f24 commit 7881365

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

bash_completion

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2008,7 +2008,7 @@ _comp_compgen_inserted_kernel_modules()
20082008
# context of current completion.
20092009
#
20102010
# @since 2.12
2011-
_comp_compgen_usergroup()
2011+
_comp_compgen_usergroups()
20122012
{
20132013
if [[ $cur == *\\\\* || $cur == *:*:* ]]; then
20142014
# Give up early on if something seems horribly wrong.
@@ -2017,16 +2017,19 @@ _comp_compgen_usergroup()
20172017
# Completing group after 'user\:gr<TAB>'.
20182018
# Reply with a list of groups prefixed with 'user:', readline will
20192019
# escape to the colon.
2020-
local _prefix
2021-
_prefix=${cur%%*([^:])}
2022-
_prefix=${_prefix//\\/}
2020+
local tmp
20232021
if [[ ${1-} == -u ]]; then
2024-
_comp_compgen -c "${cur#*:}" allowed_groups
2022+
_comp_compgen -v tmp -c "${cur#*:}" allowed_groups
20252023
else
2026-
_comp_compgen -c "${cur#*:}" -- -g
2024+
_comp_compgen -v tmp -c "${cur#*:}" -- -g
2025+
fi
2026+
if ((${#tmp[@]})); then
2027+
local _prefix=${cur%%*([^:])}
2028+
_prefix=${_prefix//\\/}
2029+
local -a _tmp=("${tmp[@]/#/$_prefix}")
2030+
_comp_unlocal tmp
2031+
_comp_compgen_set "${_tmp[@]}"
20272032
fi
2028-
((${#COMPREPLY[@]})) &&
2029-
COMPREPLY=("${COMPREPLY[@]/#/$_prefix}")
20302033
elif [[ $cur == *:* ]]; then
20312034
# Completing group after 'user:gr<TAB>'.
20322035
# Reply with a list of unprefixed groups since readline with split on :
@@ -2056,7 +2059,7 @@ _comp_compgen_allowed_users()
20562059
if _comp_as_root; then
20572060
_comp_compgen -- -u
20582061
else
2059-
_comp_compgen split -- "$(id -un 2>/dev/null || whoami 2>/dev/null)"
2062+
_comp_compgen_split -- "$(id -un 2>/dev/null || whoami 2>/dev/null)"
20602063
fi
20612064
}
20622065

@@ -2066,7 +2069,7 @@ _comp_compgen_allowed_groups()
20662069
if _comp_as_root; then
20672070
_comp_compgen -- -g
20682071
else
2069-
_comp_compgen split -- "$(id -Gn 2>/dev/null || groups 2>/dev/null)"
2072+
_comp_compgen_split -- "$(id -Gn 2>/dev/null || groups 2>/dev/null)"
20702073
fi
20712074
}
20722075

@@ -2110,7 +2113,7 @@ _comp_compgen_fstypes()
21102113
$([[ -d /etc/fs ]] && command ls /etc/fs)"
21112114
fi
21122115

2113-
[[ $_fss ]] && _comp_compgen -- -W "$_fss"
2116+
[[ $_fss ]] && _comp_compgen_split -- "$_fss"
21142117
}
21152118

21162119
# Get absolute path to a file, with rudimentary canonicalization.
@@ -2241,7 +2244,7 @@ _comp_compgen_dvd_devices()
22412244
# @since 2.12
22422245
_comp_compgen_terms()
22432246
{
2244-
_comp_compgen -a split -- "$({
2247+
_comp_compgen_split -- "$({
22452248
command sed -ne 's/^\([^[:space:]#|]\{2,\}\)|.*/\1/p' /etc/termcap
22462249
{
22472250
toe -a || toe

bash_completion.d/000_bash_completion_compat.bash

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@ _comp_deprecate_func 2.12 _kernel_versions _comp_compgen_kernel_versions
2121
_comp_deprecate_func 2.12 _uids _comp_compgen_uids
2222
_comp_deprecate_func 2.12 _gids _comp_compgen_gids
2323
_comp_deprecate_func 2.12 _xinetd_services _comp_compgen_xinetd_services
24-
_comp_deprecate_func 2.12 _terms _comp_compgen_terms
2524
_comp_deprecate_func 2.12 _pids _comp_compgen_pids
2625
_comp_deprecate_func 2.12 _pgids _comp_compgen_pgids
2726
_comp_deprecate_func 2.12 _pnames _comp_compgen_pnames
2827
_comp_deprecate_func 2.12 _modules _comp_compgen_kernel_modules
2928
_comp_deprecate_func 2.12 _installed_modules _comp_compgen_inserted_kernel_modules
30-
_comp_deprecate_func 2.12 _usergroup _comp_compgen_usergroup
29+
_comp_deprecate_func 2.12 _usergroup _comp_compgen_usergroups
3130
_comp_deprecate_func 2.12 _complete_as_root _comp_as_root
3231
_comp_deprecate_func 2.12 __load_completion _comp_load
3332

@@ -384,6 +383,12 @@ _usb_ids()
384383
_comp_compgen -a usb_ids
385384
}
386385

386+
# @deprecated 2.12 Use `_comp_compgen -a terms`
387+
_terms()
388+
{
389+
_comp_compgen -a terms
390+
}
391+
387392
# @deprecated 2.12 Use `_comp_compgen -c "${prefix:-$cur}" allowed_users`
388393
_allowed_users()
389394
{

completions/chown

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ _comp_cmd_chown()
88

99
case "$prev" in
1010
--from)
11-
_comp_compgen_usergroup
11+
_comp_compgen_usergroups
1212
return
1313
;;
1414
--reference)
@@ -35,7 +35,7 @@ _comp_cmd_chown()
3535
_comp_count_args :
3636

3737
if ((ret == 1)); then
38-
_comp_compgen_usergroup -u
38+
_comp_compgen_usergroups -u
3939
else
4040
_comp_compgen_filedir
4141
fi

completions/cpio

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ _comp_cmd_cpio()
1818
return
1919
;;
2020
--owner | -${noargopts}R)
21-
_comp_compgen_usergroup
21+
_comp_compgen_usergroups
2222
return
2323
;;
2424
--rsh-command)

0 commit comments

Comments
 (0)