Problem with extends configuration from repository

[piotar]

How are you running Renovate?

Self-hosted Renovate

Which platform you running Renovate on?

GitLab (.com or self-hosted)

Which version of Renovate are you using?

42.27.5

Please tell us more about your question or problem

For over two months, the migration of static configuration from the repository has been failing.

The extends property from the repository-provided config file is not migrated correctly when its type is a simple string.

When running in debug mode, I get the following output:

DEBUG: Found renovate.json config file (repository=frontend/abc)
DEBUG: Repository config (repository=frontend/abc)
       "fileName": "renovate.json",
       "config": {"extends": "goo/renovate-bot//presets/microfrontend"}
DEBUG: migrateAndValidate() (repository=frontend/abc)
DEBUG: No config migration necessary (repository=frontend/abc)

After that, Renovate attempts to find a preset named renovate-config-g, which suggests that the string was incorrectly transformed into an array and only the first character (g) was taken as an entry.

It seems related to this issue:
https://github.com/renovatebot/renovate/pull/37115/files

Based on the code, the extends field is destructured before migrations run, which might cause this behavior:

• https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/init/merge.ts#L214
• https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/init/merge.ts#L219

Actual behavior

• The extends value is not migrated at all (DEBUG: No config migration necessary).
• Renovate appears to destructure the extends string before migration, treating it as an array and incorrectly extracting only its first character.

Expected behavior

• The extends field provided in the repository's renovate.json (even when defined as a simple string) should be correctly migrated during the config migration phase.
• Renovate should recognize and load the preset referenced in the extends string without altering or splitting it.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[RahulGautamSingh]

Is the problem with extends within renovate config of your repo, or within the config in the static repo?

[piotar]

The migration issue only occurs with the configuration file provided by the repository.

[github-actions[bot]]

Hi there,

Please help this Discussion progress by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the reproduction in your own repository. Ensure it's actually minimal (no unnecesary dependencies or config), or it will be rejected by maintainers.
5. Install the Renovate app to verify that what you say happens (or doesn't happen) reproduces.
6. Fill out the information in your repository's README.md. What you describe there should reflect what you see in this repo, with the hosted app, and not what you saw in your original repo/environment.
7. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.
8. Add a Discussion comment mentioning that the reproduction repo is now available and linked.

If you need help with running Renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[piotar]

Minimal reproduce: https://github.com/piotar/renovate-reproductions-39659