Merge pull request #205 from clue-labs/reasons

Refactor to use HTTP response reason phrases from response object

Author: WyriHaximus

src/ResponseCodes.php

@@ -275,19 +275,22 @@ function ($error) use ($that, $conn, $request) {
     /** @internal */
     public function writeError(ConnectionInterface $conn, $code, ServerRequestInterface $request = null)
     {
-        $message = 'Error ' . $code;
-        if (isset(ResponseCodes::$statusTexts[$code])) {
-            $message .= ': ' . ResponseCodes::$statusTexts[$code];
-        }
-
         $response = new Response(
             $code,
             array(
                 'Content-Type' => 'text/plain'
             ),
-            $message
+            'Error ' . $code
         );
 
+        // append reason phrase to response body if known
+        $reason = $response->getReasonPhrase();
+        if ($reason !== '') {
+            $body = $response->getBody();
+            $body->seek(0, SEEK_END);
+            $body->write(': ' . $reason);
+        }
+
         if ($request === null) {
             $request = new ServerRequest('GET', '/', array(), null, '1.1');
         }

src/Server.php

@@ -1217,7 +1217,7 @@ function ($data) use (&$buffer) {
 
         $this->assertContains("HTTP/1.1 505 HTTP Version not supported\r\n", $buffer);
         $this->assertContains("\r\n\r\n", $buffer);
-        $this->assertContains("Error 505: HTTP Version Not Supported", $buffer);
+        $this->assertContains("Error 505: HTTP Version not supported", $buffer);
     }
 
     public function testRequestOverflowWillEmitErrorAndSendErrorResponse()