Regression in requestIdleCallback makes timeout option a no-op

[pakerwreah]

Regression in requestIdleCallback introduced by:

• Replace RuntimeSchedulerClock with HighResTimeClock #51251

The timeout is never assigned, so it is never forwarded to runtimeScheduler.

Before the PR above, it was being assigned alongside expirationTime.

With the current code the task will keep running for up to 5 minutes (default value).

react-native/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.cpp

Lines 84 to 92 in 7fa4907

	std::optional<HighResDuration> timeout;
	std::optional<HighResTimeStamp> expirationTime;
	if (options.has_value() && options.value().timeout.has_value()) {
	HighResDuration userTimeout = options.value().timeout.value();
	if (userTimeout > HighResDuration::zero()) {
	expirationTime = runtimeScheduler->now() + userTimeout;
	}
	}

react-native/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.cpp

Lines 122 to 127 in 7fa4907

	if (timeout.has_value()) {
	task = runtimeScheduler->scheduleIdleTask(
	std::move(wrappedCallback), timeout.value());
	} else {
	task = runtimeScheduler->scheduleIdleTask(std::move(wrappedCallback));
	}

Reproducer

#57571

The PR above also contains the fix for the issue.

[react-native-bot]

Warning

Missing reproducer: We could not detect a reproducible example in your issue report. Reproducers are mandatory and we can accept only one of those as a valid reproducer:

• For majority of bugs: send us a Pull Request with the RNTesterPlayground.js edited to reproduce your bug.
• If your bug is UI related: a Snack
• If your bug is build/upgrade related: a project using our Reproducer Template

You can read more about about it on our website: How to report a bug.

[pakerwreah]

Reproducer

#57571

The PR above also contains the fix for the issue.