Add the ability to provide a custom url for hermes#52459
Add the ability to provide a custom url for hermes#52459carlosalmonte04 wants to merge 1 commit into
Conversation
- This allows for a custom Hermes to be used in react native app - This is helpful when needing to share custom Hermes
|
Hi @carlosalmonte04! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Summary:
Allow usage of environment variable
RCT_HERMES_OVERRIDE_GITHUB_URL. Allows for react native apps to use a custom copy of hermes.When trying to do a security assessment of hermes I ran into issues when trying to use hermes using a local clone of the repo. I was attempting to point react native to my local copy of hermes and ran into an issue. Due to this I decided to point to my fork of hermes on github and I was able to succesfully run the app using my custom fork.
Changelog:
[GENERAL] [ADDED] - Allow to run hermes from a custom github url
Test Plan:
rm -rf ./ios/PodsRCT_BUILD_HERMES_FROM_SOURCE=true RCT_HERMES_OVERRIDE_GITHUB_URL=https://github.com/carlosalmonte04/hermes.git pod installreact-native run-ios