diff --git a/cmd/permission.go b/cmd/permission.go index 90c7ac6a6..d0e52e1de 100644 --- a/cmd/permission.go +++ b/cmd/permission.go @@ -187,6 +187,7 @@ func viewPermissionCommand(cliConfig *Config) *cli.Command { spinner.Stop() report = append(report, []string{"ID", "NAME", "NAMESPACE"}) + //nolint:staticcheck report = append(report, []string{ action.GetId(), action.GetName(), @@ -247,6 +248,7 @@ func listPermissionCommand(cliConfig *Config) *cli.Command { fmt.Printf(" \nShowing %d permission(s)\n \n", len(permissions)) report = append(report, []string{"ID", "NAME", "NAMESPACE"}) + //nolint:staticcheck for _, a := range permissions { report = append(report, []string{ a.GetId(), diff --git a/cmd/seed.go b/cmd/seed.go index 042f5614e..a34decede 100644 --- a/cmd/seed.go +++ b/cmd/seed.go @@ -112,6 +112,7 @@ func createCustomRolesAndPermissions(ctx context.Context, client frontierv1beta1 } str := "created custom permissions : " + //nolint:staticcheck for _, v := range permissionBodies { str = fmt.Sprintf("%s %s:%s", str, v.GetNamespace(), v.GetName()) resourceNamespaces = append(resourceNamespaces, v.GetNamespace()) diff --git a/cmd/serve.go b/cmd/serve.go index ae2ac1304..c73533d7f 100644 --- a/cmd/serve.go +++ b/cmd/serve.go @@ -399,7 +399,7 @@ func buildAPIDependencies( authzSchemaRepository := spicedb.NewSchemaRepository(logger, sdb) consistencyLevel := spicedb.ConsistencyLevel(cfg.SpiceDB.Consistency) - if cfg.SpiceDB.FullyConsistent { + if cfg.SpiceDB.FullyConsistent { //nolint:staticcheck consistencyLevel = spicedb.ConsistencyLevelFull } if !slices.Contains([]spicedb.ConsistencyLevel{ diff --git a/internal/api/v1beta1connect/billing_subscription.go b/internal/api/v1beta1connect/billing_subscription.go index 9f39f9c3b..7f9425ccf 100644 --- a/internal/api/v1beta1connect/billing_subscription.go +++ b/internal/api/v1beta1connect/billing_subscription.go @@ -98,6 +98,7 @@ func (h *ConnectHandler) CancelSubscription(ctx context.Context, request *connec } func (h *ConnectHandler) ChangeSubscription(ctx context.Context, request *connect.Request[frontierv1beta1.ChangeSubscriptionRequest]) (*connect.Response[frontierv1beta1.ChangeSubscriptionResponse], error) { + //nolint:staticcheck changeReq := subscription.ChangeRequest{ PlanID: request.Msg.GetPlan(), Immediate: request.Msg.GetImmediate(), diff --git a/internal/api/v1beta1connect/billing_usage.go b/internal/api/v1beta1connect/billing_usage.go index a4fd34e06..a471276be 100644 --- a/internal/api/v1beta1connect/billing_usage.go +++ b/internal/api/v1beta1connect/billing_usage.go @@ -83,6 +83,7 @@ func (h *ConnectHandler) ListBillingTransactions(ctx context.Context, request *c var transactions []*frontierv1beta1.BillingTransaction var startRange time.Time + //nolint:staticcheck if request.Msg.GetSince() != nil { startRange = request.Msg.GetSince().AsTime() } diff --git a/internal/api/v1beta1connect/permission.go b/internal/api/v1beta1connect/permission.go index 75f6d60ef..069b1d8ce 100644 --- a/internal/api/v1beta1connect/permission.go +++ b/internal/api/v1beta1connect/permission.go @@ -24,7 +24,7 @@ func (h *ConnectHandler) CreatePermission(ctx context.Context, request *connect. for _, permBody := range request.Msg.GetBodies() { permNamespace, permName := schema.PermissionNamespaceAndNameFromKey(permBody.GetKey()) if permNamespace == "" || permName == "" { - permNamespace, permName = permBody.GetNamespace(), permBody.GetName() + permNamespace, permName = permBody.GetNamespace(), permBody.GetName() //nolint:staticcheck } if permName == "" || permNamespace == "" { return nil, connect.NewError(connect.CodeInvalidArgument, ErrBadRequest) @@ -116,7 +116,7 @@ func (h *ConnectHandler) UpdatePermission(ctx context.Context, request *connect. permNamespace, permName := schema.PermissionNamespaceAndNameFromKey(request.Msg.GetBody().GetKey()) if permNamespace == "" || permName == "" { - permNamespace, permName = request.Msg.GetBody().GetNamespace(), request.Msg.GetBody().GetName() + permNamespace, permName = request.Msg.GetBody().GetNamespace(), request.Msg.GetBody().GetName() //nolint:staticcheck } updatedPermission, err := h.permissionService.Update(ctx, permission.Permission{ ID: request.Msg.GetId(), diff --git a/internal/api/v1beta1connect/permission_check.go b/internal/api/v1beta1connect/permission_check.go index 3fc2ea8d1..5760895df 100644 --- a/internal/api/v1beta1connect/permission_check.go +++ b/internal/api/v1beta1connect/permission_check.go @@ -156,6 +156,7 @@ func (h *ConnectHandler) CheckResourcePermission(ctx context.Context, req *conne errorLogger := NewErrorLogger() objectNamespace, objectID, err := schema.SplitNamespaceAndResourceID(req.Msg.GetResource()) + //nolint:staticcheck if len(req.Msg.GetResource()) == 0 || err != nil { objectNamespace = schema.ParseNamespaceAliasIfRequired(req.Msg.GetObjectNamespace()) objectID = req.Msg.GetObjectId() diff --git a/internal/reconcile/permission_reconciler.go b/internal/reconcile/permission_reconciler.go index 9600917d1..b28c58534 100644 --- a/internal/reconcile/permission_reconciler.go +++ b/internal/reconcile/permission_reconciler.go @@ -91,6 +91,7 @@ func (r *PermissionReconciler) fetchCurrent(ctx context.Context) ([]currentPermi return nil, fmt.Errorf("list permissions: %w", err) } var current []currentPermission + //nolint:staticcheck for _, p := range resp.Msg.GetPermissions() { if isBaseNamespace(p.GetNamespace()) { continue diff --git a/internal/store/spicedb/relation_repository.go b/internal/store/spicedb/relation_repository.go index bd6b21d7d..908e320a1 100644 --- a/internal/store/spicedb/relation_repository.go +++ b/internal/store/spicedb/relation_repository.go @@ -10,7 +10,7 @@ import ( "sync/atomic" authzedpb "github.com/authzed/authzed-go/proto/authzed/api/v1" - newrelic "github.com/newrelic/go-agent" + newrelic "github.com/newrelic/go-agent" //nolint:staticcheck "github.com/raystack/frontier/core/relation" ) diff --git a/pkg/db/db.go b/pkg/db/db.go index f3a563423..92f00e97c 100644 --- a/pkg/db/db.go +++ b/pkg/db/db.go @@ -12,7 +12,7 @@ import ( "github.com/raystack/frontier/internal/metrics" - newrelic "github.com/newrelic/go-agent" + newrelic "github.com/newrelic/go-agent" //nolint:staticcheck "github.com/jmoiron/sqlx" ) diff --git a/test/e2e/regression/billing_test.go b/test/e2e/regression/billing_test.go index ab4e5ca13..e7cba109c 100644 --- a/test/e2e/regression/billing_test.go +++ b/test/e2e/regression/billing_test.go @@ -1068,6 +1068,7 @@ func (s *BillingRegressionTestSuite) TestUsageAPI() { beforeBalance := getBalanceResp.Msg.GetBalance().GetAmount() // set limit to -20 + //nolint:staticcheck _, err = s.testBench.AdminClient.UpdateBillingAccountLimits(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.UpdateBillingAccountLimitsRequest{ OrgId: createOrgResp.Msg.GetOrganization().GetId(), Id: createBillingResp.Msg.GetBillingAccount().GetId(), @@ -1129,6 +1130,7 @@ func (s *BillingRegressionTestSuite) TestUsageAPI() { s.Assert().NoError(err) // reset limit + //nolint:staticcheck _, err = s.testBench.AdminClient.UpdateBillingAccountLimits(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.UpdateBillingAccountLimitsRequest{ OrgId: createOrgResp.Msg.GetOrganization().GetId(), Id: createBillingResp.Msg.GetBillingAccount().GetId(), diff --git a/test/e2e/regression/service_registration_test.go b/test/e2e/regression/service_registration_test.go index 685700f3a..4ad0776cf 100644 --- a/test/e2e/regression/service_registration_test.go +++ b/test/e2e/regression/service_registration_test.go @@ -153,6 +153,7 @@ func (s *ServiceRegistrationRegressionTestSuite) TestServiceRegistration() { var lastPermCount int for _, perm := range []string{"get", "update", "delete"} { for _, listPerm := range listPermResp.Msg.GetPermissions() { + //nolint:staticcheck if listPerm.GetName() == perm && listPerm.GetNamespace() == "database/instance" { lastPermCount++ } @@ -235,6 +236,7 @@ func (s *ServiceRegistrationRegressionTestSuite) TestPermissionDeleteCascade() { s.Require().NoError(err) var builtinID string for _, p := range listResp.Msg.GetPermissions() { + //nolint:staticcheck if p.GetNamespace() == "app/organization" && p.GetName() == "get" { builtinID = p.GetId() break