change compact display selector to adjust font size only on the body … #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of all elements
Author
|
Once you use the @media (min-width: 992px)
body.display--compact * {
font-size: 14px;
}So if you'd like to set the font size of any other element with css, you'd be writing something like this: .breadcrumb-item a,
@media (min-width: 992px) body.display--compact .breadcrumb-item a {
font-size: 12px;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When currently using the
body.display--compactclass, it makes ALL child elements having the font-size. This means that all get overridden unless specifically set in css.I think this should be more like how bootstrap does set the website font-size, which can be seen in
_reboot.scss:Should use the same way if you want global font-size adjustments. This pull request does exactly that.