login & sign up page design #237
Conversation
✅ Deploy Preview for pyladiescon-portal-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the PR. Would you mind sharing some screenshots of how it looks like with this style change? |
|
Also the tests are failing. Please check and fix the errors. |
|
Fixed related errors causing page malfunction and improved overall UI stability. 
|
|
Please remove the entire |
| <header class="card-header text-center py-4 bg-transparent border-0"> | ||
| <div class="brand d-flex justify-content-center mb-2" aria-hidden="true"> | ||
| <!-- simple inline SVG logo --> | ||
| <svg width="56" height="56" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" class="logo"> |
There was a problem hiding this comment.
Should this be using the logo.svg file? Currently it looks like a blue icon.
|
The "Forgot password" link appears twice in the page. Can we keep just one? I like the one below the "Sign in" button. |
| {% endif %} | ||
| {% endblock extra_body %} | ||
| <!-- Accessibility + small UX improvements: autofocus first input, show/hide password --> | ||
| <script> |
There was a problem hiding this comment.
What is the purpose of this script?
| <header class="card-header text-center py-4 bg-transparent border-0"> | ||
| <div class="brand d-flex justify-content-center mb-3" aria-hidden="true"> | ||
| <!-- inline SVG logo --> | ||
| <svg width="64" height="64" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" class="logo"> |
There was a problem hiding this comment.
Should this be displaying the logo in img/logo.svg?
| {% trans "Create your account" %} | ||
| {% endelement %} | ||
| {% element p class="muted small mt-2 mb-0" %} | ||
| {% trans "Join the community — create an account to register for events, manage your profile, and more." %} |
There was a problem hiding this comment.
| {% trans "Join the community — create an account to register for events, manage your profile, and more." %} | |
| {% trans "Join the community. Create an account to volunteer with PyLadiesCon." %} |
| </div> | ||
| {% endif %} | ||
|
|
||
| <p class="small text-muted mb-0">{% trans "By signing up you agree to the Code of Conduct and Terms of Service." %}</p> |
There was a problem hiding this comment.
Can this be moved to be closer to where the CoC and ToS checkboxes are? Eg under the "Agreements" heading.
| {% endblock content %} | ||
| </div> | ||
|
|
||
| <footer class="card-footer bg-transparent text-center py-3 border-0"> |
There was a problem hiding this comment.
We can remove the footer. The page footer already has info on how to get help (which is by visiting our GitHub repo).
| {% if SOCIALACCOUNT_ENABLED %} | ||
| {% include "socialaccount/snippets/login.html" with page_layout="entrance" %} | ||
| {% endif %} | ||
| <link rel="stylesheet" href="{% static 'css/custom-login.css' %}"> |
There was a problem hiding this comment.
Could this be added to the extra_head block instead of in the content block?
| rel="noopener noreferrer">Code of Conduct</a> | ||
| </label> | ||
| {% if form.coc_agreement.errors %} | ||
| <link rel="stylesheet" href="{% static 'css/custom-login.css' %}"> |
There was a problem hiding this comment.
Could this be added to the extra_head block instead of in the content block?
|
Please check the failing test. |
3 participants
No description provided.