Current edit description logic isn't enough

[Leonabcd123]

In the find_description_edit_url function, we just check whether the dojo is official and is a repository. This check isn't enough, as there are some repos (e.g. the course ones), that are official, but when you click on the edit description button, it redirects to a non-existent page.

Suggestion: Add a field in the dojo.yml file that allows the creator to specify whether he wants the edit description button or not. Another way would be to just check whether that path exists before redirecting to it.

Another problem that I found is that repositories that have been relocated (like the arm dojo's repo, that originated in robwaz/arm-dojo, but has since been relocated to https://github.com/pwncollege/arm-dojo) are still the ones that the edit button redirects to, instead of the new repository.

[zardus]

I'm not sure if we need to complicate the yml further... What if we just add a check to make sure the dojo isn't a course?

[Leonabcd123]

I don't really like this solution, because it's less robust and there are (or will be) offical dojos that are closed source, so the edit description button won't work for them.

[zardus]

True, but that way would be a one-line change, and we can always pursue the more complete solution later when it becomes apparent that we need it :-)

…

On Tue, Oct 14, 2025 at 8:43 PM Leonabcd123 ***@***.***> wrote: *Leonabcd123* left a comment (pwncollege/dojo#942) <https://urldefense.com/v3/__https://github.com/pwncollege/dojo/issues/942*issuecomment-3404402611__;Iw!!IKRxdwAv5BmarQ!eFTB3ZS3OBxrOL-8q63yTSi6LRFXRLaMnkocxcSf-Oqal9FNzU7mBwVPL1OPpXmxwK9XcScb1XXVnCk3-_Xz8MfjQvo4$> I don't really like this solution, because it's less robust and there are (or will be) offical dojos that are closed source, so the edit description button won't work for them. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/pwncollege/dojo/issues/942*issuecomment-3404402611__;Iw!!IKRxdwAv5BmarQ!eFTB3ZS3OBxrOL-8q63yTSi6LRFXRLaMnkocxcSf-Oqal9FNzU7mBwVPL1OPpXmxwK9XcScb1XXVnCk3-_Xz8MfjQvo4$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA2LHF6U76DDQHBVUTJXZ3T3XW7GNAVCNFSM6AAAAACIXYS2H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBUGQYDENRRGE__;!!IKRxdwAv5BmarQ!eFTB3ZS3OBxrOL-8q63yTSi6LRFXRLaMnkocxcSf-Oqal9FNzU7mBwVPL1OPpXmxwK9XcScb1XXVnCk3-_Xz8MZvAYsX$> . You are receiving this because you commented.Message ID: ***@***.***>

[Leonabcd123]

I believe that we already need the more complete solution, for dojos such as intro-to-programming-languages that are official and closed source. Another thing is, when dojos become official, everyone can view the name and creator of the private repo, which I feel like exposes some information that the dojo creator may not have wanted to expose.

[zardus]

All of the current official, non-course dojos are open source, though... Intro to Cybersecurity is right here: https://github.com/pwncollege/intro-to-cybersecurity-dojo/

One thing that we could also do is check if the github repo is public? I could see that being an elegant solution as well.

[Leonabcd123]

I thought it was closed source because it redirected to a non-existent page (pwn-compsci/intro-to-programming-languages). This is another problem, as there should be a way to update the repository a dojo is based on. But for this issue, let's go through with the check whether the repo is public.

[Leonabcd123]

This also makes me wonder how is the dojo being updated? If the repository the dojo is based on is the old one, won't update_dojo try to update from that one, and not the new one?

I'm going off track here, we can open another issue for that.

[Leonabcd123]

Just realized I originally wrote intro-to-cybersecurity instead of intro-to-programming-languages. Sorry for the confusion.

[zardus]

Oh, you are correct --- that one is closed (due to the testcases)!

Okay, so the plan is:

• when we're pulling a repo on creation/update, we also check over https and see if the repo returns a 404
• based on the result of that, we set dojo.data['public_repository'] to True or False
• instead of the official/etc check, we check dojo.data['public_repository'] when determining whether to display the edit buttons

[zardus]

And as a separate thing we can address in a different issue, we should support updating the repository url (probably in the admin page).

[Leonabcd123]

Great! We can also use this logic for dojo creation for non-existent repositories. Currently, when you try to create a dojo from a repository that doesn't exist, it gives you this error:
Failed to clone: add deploy key
We can check whether the dojo exist (with the check you mentioned), and give a different error message if that's the case.

[Leonabcd123]

I'm just not sure if checking on creation/update is enough. What if someone creates a dojo, removes one of the challenges but forgets to update the dojo? The edit description button will still try to link to a now non-existent page. This is a pretty niche edge case, but I think we should do this check in the find_description_edit_url.

[zardus]

I don't think we should worry about the edge cases... If we reached out to github every time someone opens a module, the dojo will melt down :').

Let's implement the common case (check-during-update), and then deal with corner cases if they really become a problem.