Community dojo reward 2+ code point emojis

[fluffy-flufff]

Currently if the dojo reward is set to any emojis with more than 1 code point such as 🕸️(U+1F578 U+FE0F), 🐻‍❄️(U+1F43B U+200D U+2744 U+FE0F), the dojo will fail to update due to dojo.yml parsing error

[fluffy-flufff]

One of the ways I can think of to parse emoji without limiting to 1 code point and risk letting people put arbitrary bytes into the award field would be the library emoji.

Here are some test cases I came up with

>>> print(emoji.is_emoji("🦊"))
True
>>> print(emoji.is_emoji("🕷️"))
True
>>> print(emoji.is_emoji("🐈‍⬛"))
True
>>> print(emoji.is_emoji("🐻‍❄️"))
True
>>> print(emoji.is_emoji("🐶🐱"))
False
>>> print(emoji.is_emoji("\x00🐱"))
False

[zardus]

I like the proposal! Do you want to send a PR?

[fluffy-flufff]

Yes, I'll go through the parsing part of dojo and send a PR when I have a minute!

[Leonabcd123]

Pretty sure we just need to change this part in DOJO_SPEC:

Optional("award"): {
    Optional("emoji"): Regex(r"^\S$"),
    Optional("belt"): IMAGE_REGEX
}

This regex currently only matches one non whitespace character. Replacing it with your example (emoji.is_emoji()) should do the trick (I would've submitted a PR, but I just don't want to take credit for your work).

[fluffy-flufff]

@Leonabcd123 please go ahead. I'm having too much on my plate right now so I doubt I'd be able to send a PR anytime soon.

[fluffy-flufff]

I'm thinking about creating a new tests for this? The current simple_award_dojo has 🧪 award which is only one code point (U+1F9EA). Maybe we could create one for 2,3, and 4 code point awards or just one for a 4 code point award (like 🐻‍❄️).

I seem to can't push my commit to #953 , but a simple dojo test like this would work:

id: multi-code-point-award
type: public
award:
  emoji: 🐻‍❄️

the rest should be the same as simple_award_dojo.yml.

[Leonabcd123]

Just added them (really hope I did this right).

[fluffy-flufff]

@Leonabcd123 I think some of the test cases failed. I'll take a look when I set up my ubuntu rig.