fix(e2e): resourcepool condition #1773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CorentinPtrl <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes the resource pool condition message assertions in E2E tests by replacing exact string matching with a more flexible parsing approach. This change makes the tests more resilient to variations in message formatting and field ordering.
Key Changes:
- Introduced
extractResourcePoolMessage()helper to parse condition messages into structured key-value pairs - Added
containsAll()helper for order-independent assertion checking - Updated six test cases to use the new flexible assertion pattern instead of exact string matching
prometherion
reviewed
Dec 5, 2025
Member
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
LGTM, worth giving it a try in the ci /cc @oliverbaehler
Collaborator
|
Yeah that will do for now. However this is fighting the snytome, not the cause. I would suspect the ordering is incirrect therefor leading to inconsistent status messages. I will have to refactor the status handling anyway for resourcepools in the upcoming release |
oliverbaehler
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625