Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 4, 2025

No description provided.

Copy link
Member Author

Sysix commented Dec 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Dec 4, 2025
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 4, 2025
@Sysix Sysix marked this pull request as ready for review December 4, 2025 20:00
@Sysix Sysix requested a review from camc314 as a code owner December 4, 2025 20:00
Copilot AI review requested due to automatic review settings December 4, 2025 20:00
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
Copy link
Member Author

Sysix commented Dec 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-04-test_oxlint_lsp_add_codeaction.is_preferred_info_to_snapshot_files branch from e12d085 to a7fa043 Compare December 4, 2025 20:01
Copilot finished reviewing on behalf of Sysix December 4, 2025 20:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances test snapshot files by adding CodeAction.is_preferred field information. The change improves test coverage by capturing whether code actions are marked as preferred in the Language Server Protocol (LSP) responses, which helps verify that the most appropriate fixes are correctly marked for IDE auto-fix functionality.

  • Added is_preferred output to the get_snapshot_for_code_action function using debug formatting
  • Updated all 17 snapshot files that contain code actions with the new field
  • Preferred actions (actual fixes) show Some(true), while alternative fixes and disable-rule actions show Some(false)

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/oxc_language_server/src/linter/tester.rs Added writeln statement to include is_preferred field in code action snapshots
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 6 code actions (fixes and disable options)
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 9 code actions (various fixes and disable options)
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 4 code actions related to floating promises
crates/oxc_language_server/src/linter/snapshots/fixtures_linter_tsgolint@no-floating-promises__index.ts.snap Updated snapshot with is_preferred values for 20 code actions involving promise handling
crates/oxc_language_server/src/linter/snapshots/fixtures_linter_ts_path_alias@deep__src__dep-a.ts.snap Updated snapshot with is_preferred values for 2 code actions for cycle detection
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 7 code actions in Svelte files
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 5 code actions related to regex patterns
crates/oxc_language_server/src/linter/snapshots/fixtures_linter_multiple_suggestions@forward_ref.ts.snap Updated snapshot with is_preferred values for 4 code actions with multiple fix suggestions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 3 debugger-related code actions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 4 code actions for boolean cast and optional chain issues
crates/oxc_language_server/src/linter/snapshots/[email protected]_another_config__not-ignored-file.ts.snap Updated snapshot with is_preferred values for 3 debugger-related code actions
crates/oxc_language_server/src/linter/snapshots/fixtures_linter_deny_no_console@hello_world.js.snap Updated snapshot with is_preferred values for 2 console-related code actions
crates/oxc_language_server/src/linter/snapshots/[email protected]_folder__folder-dep-a.ts.snap Updated snapshot with is_preferred values for 2 cycle detection code actions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 2 cycle detection code actions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 2 cycle detection code actions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 3 debugger-related code actions
crates/oxc_language_server/src/linter/snapshots/[email protected] Updated snapshot with is_preferred values for 12 debugger-related code actions in Astro files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot merged commit a7fa043 into main Dec 4, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-04-test_oxlint_lsp_add_codeaction.is_preferred_info_to_snapshot_files branch December 4, 2025 20:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants