🐛 add nil-pointer check in issueActivityByProjectMember (#4642)

AuthorAssociation can technically be nil so add two checks

Signed-off-by: Adam Korczynski <[email protected]>

Author: AdamKorcz

probes/issueActivityByProjectMember/impl.go

@@ -90,12 +90,18 @@ func hasActivityByCollaboratorOrHigher(issue *clients.Issue, threshold time.Time
 		return false
 	}
 
-	if issue.AuthorAssociation.Gte(clients.RepoAssociationCollaborator) &&
+	hasAuthorAssociation := issue.AuthorAssociation != nil
+
+	if hasAuthorAssociation &&
+		issue.AuthorAssociation.Gte(clients.RepoAssociationCollaborator) &&
 		issue.CreatedAt != nil && issue.CreatedAt.After(threshold) {
 		// The creator of the issue is a collaborator or higher.
 		return true
 	}
 	for _, comment := range issue.Comments {
+		if comment.AuthorAssociation == nil {
+			continue
+		}
 		if comment.AuthorAssociation.Gte(clients.RepoAssociationCollaborator) &&
 			comment.CreatedAt != nil &&
 			comment.CreatedAt.After(threshold) {

probes/issueActivityByProjectMember/impl_test.go

@@ -225,6 +225,22 @@ func Test_hasActivityByCollaboratorOrHigher(t *testing.T) {
 			},
 			want: true,
 		},
+		{
+			name: "issue with nil AuthorAssociation",
+			args: args{
+				issue: &clients.Issue{
+					CreatedAt:         &twentyDaysAgo,
+					AuthorAssociation: nil,
+					Comments: []clients.IssueComment{
+						{
+							CreatedAt:         &twentyDaysAgo,
+							AuthorAssociation: nil,
+						},
+					},
+				},
+			},
+			want: false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {