build error under windows using VS2015 #1283
Description
By building the current version with VS2015 I have found the following problems:
-
in SparseMatrix, SparseBinaryMatrix please do NOT use
using Serializable::write;
using Serializable::read;
I remember, I have discussed with @rcrowder last year, but it is not fixed. -
In Topology.cpp, it is not allowed to use std::max() for special data type of nupic.
For example in the line 101
offset_[i] = std::max((Int)offset_[i], -(Int)neighborhood_.centerPosition_[i]);
-->
offset_[i] = offset_[i] < -(Int)neighborhood_.centerPosition_[i] ? -(Int)neighborhood_.centerPosition_[i] : offset_[i];
line 152:
offset_[i] = std::max(-(Int)neighborhood_.radius_, -(Int)neighborhood_.centerPosition_[i]);
-->
if (-neighborhood_.radius_ < -neighborhood_.centerPosition_[i]) offset_[i] = -neighborhood_.centerPosition_[i];
else offset_[i] = -neighborhood_.radius_;
3. there are a lot of error by unit test, like
const UInt zeroColumns[0] = {}; //not allowed
vector var = {1.0, 1.2};