From 88c47b15eb383098e73b9bee4e7242149b4f1a05 Mon Sep 17 00:00:00 2001 From: "Martin Hinshelwood NKDAgility.com" Date: Wed, 12 Nov 2025 10:00:09 -0500 Subject: [PATCH] Refactor GetFieldMappings for clarity and flexibility Refactored the `GetFieldMappings` method in `FieldMappingTool.cs` to improve code clarity and functionality. Introduced a `result` list to aggregate both global (`"*"` wildcard) and specific mappings for a given work item type. The method now returns a combined list of mappings, ensuring both global and specific mappings are considered when applicable. Co-authored-by: Mattias Nielsen --- src/MigrationTools/Tools/FieldMappingTool.cs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/MigrationTools/Tools/FieldMappingTool.cs b/src/MigrationTools/Tools/FieldMappingTool.cs index 23b22ff10..a9c58f63a 100644 --- a/src/MigrationTools/Tools/FieldMappingTool.cs +++ b/src/MigrationTools/Tools/FieldMappingTool.cs @@ -73,15 +73,16 @@ public void AddFieldMap(string workItemTypeName, IFieldMap fieldToTagFieldMap) public List GetFieldMappings(string witName) { - if (_fieldMaps.TryGetValue("*", out List fieldMaps)) + var result = new List(); + if (_fieldMaps.TryGetValue("*", out var globalMaps)) { - return fieldMaps; + result.AddRange(globalMaps); } - else if (_fieldMaps.TryGetValue(witName, out fieldMaps)) + if (_fieldMaps.TryGetValue(witName, out var specificMaps)) { - return fieldMaps; + result.AddRange(specificMaps); } - return []; + return result; } public void ApplyFieldMappings(WorkItemData source, WorkItemData target)