Fix warnings (#3056)

I do not like warnings, because I treat them as potential errors. :) So
I fixed all warnings in the project, that could be fixed. Remaining
warnings during build are now only those regarding mixing old and new
.NET.

## Fixed warnings

- `CS0168` The variable 'ex' is declared but never used
- `MSTEST0001` Explicitly enable or disable tests parallelization
(https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001)
- `MSTEST0017` Assertion arguments should be passed in the correct
order. 'actual' and 'expected'/'notExpected' arguments have been
swapped.
- `MSTEST0037` Use proper asertion methods:
  - Use 'Assert.IsEmpty' instead of 'Assert.AreEqual'
  - Use 'Assert.HasCount' instead of 'Assert.AreEqual'
  - Use 'Assert.IsTrue' instead of 'Assert.AreEqual'
  - Use 'Assert.AreEqual' instead of 'Assert.IsTrue'
- `MSTEST0044` 'DataTestMethod' is obsolete. Use 'TestMethod' instead.
- `MSTEST0056` Use the 'DisplayName' property instead of passing a
string argument to TestMethodAttribute
- `NU1504` Duplicate 'PackageReference' items found. Remove the
duplicate items or use the Update functionality to ensure a consistent
restore behavior. The duplicate 'PackageReference' items are:
Newtonsoft.Json , Newtonsoft.Json.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

* **Tests**
  * Enabled parallel test execution at class level across test suites.
  * Updated test assertions for consistency and standardisation.

* **Chores**
  * Removed unused JSON serialisation package dependencies.
  * Cleaned up imports and improved code formatting throughout tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: MrHinsh

src/MigrationTools.Clients.AzureDevops.Rest.Tests/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]

src/MigrationTools.Clients.FileSystem.Tests/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]

src/MigrationTools.Clients.TfsObjectModel.Tests/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]

src/MigrationTools.Clients.TfsObjectModel.Tests/Processors/TfsSharedQueryProcessorTests.cs

@@ -1,23 +1,18 @@
-using System.Collections.Generic;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
-using MigrationTools.Endpoints;
-using MigrationTools.Tests;
-using MigrationTools.Processors.Infrastructure;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace MigrationTools.Processors.Tests
 {
     [TestClass()]
     public class TfsSharedQueryProcessorTests : TfsProcessorTests
     {
-        [TestMethod("TfsSharedQueryProcessorTests_Incantate"), TestCategory("L0")]
+        [TestMethod(DisplayName = "TfsSharedQueryProcessorTests_Incantate"), TestCategory("L0")]
         public void Incantate()
         {
             var x = GetTfsSharedQueryProcessor();
             Assert.IsNotNull(x);
         }
 
-        [TestMethod("TfsSharedQueryProcessorTests_BasicConfigure"), TestCategory("L0")]
+        [TestMethod(DisplayName = "TfsSharedQueryProcessorTests_BasicConfigure"), TestCategory("L0")]
         public void BasicConfigure()
         {
             var y = new TfsSharedQueryProcessorOptions
@@ -33,7 +28,7 @@ public void BasicConfigure()
             Assert.AreEqual("fortyTwo", x.Options.RefName);
         }
 
-        [TestMethod("TfsSharedQueryProcessorTests_BasicRun"), TestCategory("L0")]
+        [TestMethod(DisplayName = "TfsSharedQueryProcessorTests_BasicRun"), TestCategory("L0")]
         public void BasicRun()
         {
             var y = new TfsSharedQueryProcessorOptions
@@ -48,4 +43,4 @@ public void BasicRun()
             Assert.IsNotNull(x);
         }
     }
-}
+}

src/MigrationTools.Clients.TfsObjectModel.Tests/Processors/TfsTeamSettingsProcessorTests.cs

@@ -1,5 +1,4 @@
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
 using MigrationTools.Processors.Infrastructure;
 
 namespace MigrationTools.Processors.Tests
@@ -28,7 +27,7 @@ public void TfsTeamSettingsProcessorConfigureTest()
             };
             var x = GetTfsTeamSettingsProcessor(y);
             Assert.IsNotNull(x);
-            Assert.AreEqual(x.Options.SourceName, "TfsTeamSettingsSource");
+            Assert.AreEqual("TfsTeamSettingsSource", x.Options.SourceName);
             Assert.IsNotNull(x.Source);
         }
 
@@ -41,4 +40,4 @@ public void TfsTeamSettingsProcessorNoEnrichersTest()
             Assert.AreEqual(ProcessingStatus.Complete, processor.Status);
         }
     }
-}
+}

src/MigrationTools.Clients.TfsObjectModel.Tests/Processors/TfsWorkItemMigrationProcessorTests.cs

@@ -1,9 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using Microsoft.Extensions.Options;
+using Microsoft.Extensions.Options;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace MigrationTools.Processors.Tests
@@ -12,15 +7,15 @@ namespace MigrationTools.Processors.Tests
     public class TfsWorkItemMigrationProcessorTests
     {
 
-        [TestMethod("TfsWorkItemMigrationProcessorTests_OptionsValidator_Empty"), TestCategory("L0")]
+        [TestMethod(DisplayName = "TfsWorkItemMigrationProcessorTests_OptionsValidator_Empty"), TestCategory("L0")]
         public void OptionsValidator_Empty()
         {
             var validator = new TfsWorkItemMigrationProcessorOptionsValidator();
             var x = new TfsWorkItemMigrationProcessorOptions();
             Assert.IsTrue(validator.Validate(null, x).Failed);
         }
 
-        [TestMethod("TfsWorkItemMigrationProcessorTests_OptionsValidator_Valid"), TestCategory("L0")]
+        [TestMethod(DisplayName = "TfsWorkItemMigrationProcessorTests_OptionsValidator_Valid"), TestCategory("L0")]
         public void OptionsValidator_Valid()
         {
             var validator = new TfsWorkItemMigrationProcessorOptionsValidator();

src/MigrationTools.Clients.TfsObjectModel.Tests/Tools/TfsRevisionManagerTests.cs

@@ -4,7 +4,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using MigrationTools.DataContracts;
-using MigrationTools.Tests;
 using MigrationTools.Tools;
 
 
@@ -38,8 +37,7 @@ public void TfsRevisionManagerToolInSync1()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(revs.Count, 0);
-
+            Assert.IsEmpty(revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -53,8 +51,7 @@ public void TfsRevisionManagerToolInSync10()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(0, revs.Count);
-
+            Assert.IsEmpty(revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -68,7 +65,7 @@ public void TfsRevisionManagerToolSync1()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(1, revs.Count);
+            Assert.HasCount(1, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -82,7 +79,7 @@ public void TfsRevisionManagerToolSync10()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(10, revs.Count);
+            Assert.HasCount(10, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -101,7 +98,7 @@ public void TfsRevisionManagerToolReplayRevisionsOff()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(1, revs.Count);
+            Assert.HasCount(1, revs);
         }
 
 
@@ -121,7 +118,7 @@ public void TfsRevisionManagerToolMaxRevision51()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(0, revs.Count);
+            Assert.IsEmpty(revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -140,7 +137,7 @@ public void TfsRevisionManagerToolMaxRevision56()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(5, revs.Count);
+            Assert.HasCount(5, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -158,7 +155,7 @@ public void TfsRevisionManagerToolMaxRevision59()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, null);
 
-            Assert.AreEqual(5, revs.Count);
+            Assert.HasCount(5, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -170,7 +167,7 @@ public void TfsRevisionManagerToolDatesMustBeIncreasing()
             List<RevisionItem> source = GetWorkItemWithRevisions(currentDateTime, 1, 10, false);
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, null);
-            Assert.AreEqual(true, CheckDateIncreasing(revs));
+            Assert.IsTrue(CheckDateIncreasing(revs));
         }
 
         private static bool CheckDateIncreasing(List<RevisionItem> revs)

src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs

@@ -439,7 +439,7 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork
                     newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value = oldWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value;
                 }
             }
-            catch (FieldDefinitionNotExistException ex)
+            catch (FieldDefinitionNotExistException)
             {
                 // Eat exception coz the TFS API Sucks
             }

src/MigrationTools.ConsoleDataGenerator/MigrationTools.ConsoleDataGenerator.csproj

@@ -28,8 +28,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Options" />
     <PackageReference Include="YamlDotNet" />
-    <PackageReference Include="Newtonsoft.Json" />
-    <PackageReference Include="Newtonsoft.Json.Schema" />
   </ItemGroup>
 
   <ItemGroup>

src/MigrationTools.Host.Tests/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]