feat: refactor sharedItemsStore to composition api store

Signed-off-by: Dorra Jaouad <[email protected]>

Author: DorraJaouad

src/components/RightSidebar/SharedItems/SharedItemsTab.vue

@@ -75,7 +75,7 @@ const hasMoreThreads = computed(() => chatExtrasStore.getThreadsList(token.value
 
 watch([token, () => props.active, () => sidebarStore.show], ([token, isActive, isOpen]) => {
 	if (token && isActive && isOpen) {
-		sharedItemsStore.getSharedItemsOverview(token)
+		sharedItemsStore.fetchSharedItemsOverview(token)
 		supportThreads.value && chatExtrasStore.fetchRecentThreadsList(token)
 	}
 }, { immediate: true })

src/stores/__tests__/sharedItems.spec.js

@@ -60,23 +60,6 @@ describe('sharedItemsStore', () => {
 			expect(sharedItemsStore.sharedItems(token)).toEqual({ media: { 1: message } })
 		})
 
-		it('does not overwrite store with overview response', async () => {
-			// Arrange
-			const message = {
-				id: 100,
-				token,
-				message: '{file}',
-				messageParameters: { file: { mimetype: 'image/jpeg' } },
-			}
-			sharedItemsStore.addSharedItemFromMessage(token, message)
-
-			// Act
-			sharedItemsStore.addSharedItemsFromOverview(token, payloadOverview)
-
-			// Assert
-			expect(sharedItemsStore.sharedItems(token).media).toEqual({ 100: message })
-		})
-
 		it('processes an array of messages and add each unique item only once', () => {
 			// Arrange
 			const message1 = {
@@ -105,10 +88,10 @@ describe('sharedItemsStore', () => {
 			// Arrange
 			const response = generateOCSResponse({ payload: payloadOverview })
 			getSharedItemsOverview.mockResolvedValue(response)
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Act
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Assert
 			expect(getSharedItemsOverview).toHaveBeenCalledTimes(1)
@@ -122,7 +105,7 @@ describe('sharedItemsStore', () => {
 			getSharedItemsOverview.mockResolvedValueOnce(response)
 
 			// Act: load sharedItemsOverview from server
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Assert
 			expect(getSharedItemsOverview).toHaveBeenCalledWith({ token, limit: limitOverview })
@@ -143,10 +126,10 @@ describe('sharedItemsStore', () => {
 			getSharedItemsOverview.mockResolvedValueOnce(responseOverview)
 			const response = generateOCSResponse({ payload: { 1: message } })
 			getSharedItems.mockResolvedValueOnce(response)
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Act: load sharedItemsOverview from server
-			await sharedItemsStore.getSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
+			await sharedItemsStore.fetchSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
 
 			// Assert
 			expect(getSharedItems).toHaveBeenCalledWith({
@@ -164,10 +147,10 @@ describe('sharedItemsStore', () => {
 			getSharedItemsOverview.mockResolvedValueOnce(responseOverview)
 			const response = generateOCSResponse({ payload: [] })
 			getSharedItems.mockResolvedValueOnce(response)
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Act: load sharedItemsOverview from server
-			const output = await sharedItemsStore.getSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
+			const output = await sharedItemsStore.fetchSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
 
 			// Assert
 			expect(getSharedItems).toHaveBeenCalledWith({
@@ -192,15 +175,15 @@ describe('sharedItemsStore', () => {
 			getSharedItemsOverview.mockRejectedValueOnce(response)
 
 			// Act
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			// Assert: store hasn't changed
 			expect(sharedItemsStore.sharedItems(token)).toEqual({})
 		})
 
 		it('skips server request without initially loaded overview', async () => {
 			// Act
-			await sharedItemsStore.getSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
+			await sharedItemsStore.fetchSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
 
 			// Assert: store hasn't changed
 			expect(getSharedItems).not.toHaveBeenCalled()
@@ -211,13 +194,13 @@ describe('sharedItemsStore', () => {
 			// Arrange
 			const responseOverview = generateOCSResponse({ payload: payloadOverview })
 			getSharedItemsOverview.mockResolvedValueOnce(responseOverview)
-			await sharedItemsStore.getSharedItemsOverview(token)
+			await sharedItemsStore.fetchSharedItemsOverview(token)
 
 			const response = generateOCSErrorResponse({ status: 404, payload: [] })
 			getSharedItems.mockRejectedValueOnce(response)
 
 			// Act
-			await sharedItemsStore.getSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
+			await sharedItemsStore.fetchSharedItems(token, SHARED_ITEM.TYPES.MEDIA)
 
 			// Assert: store hasn't changed
 			expect(sharedItemsStore.sharedItems(token)).toEqual(result)