swapped isset for array_key_exists

Author: transistive

src/Types/CypherList.php

@@ -14,6 +14,7 @@
 namespace Laudis\Neo4j\Types;
 
 use function array_filter;
+use function array_key_exists;
 use function array_key_last;
 use function array_map;
 use function array_reduce;
@@ -90,7 +91,7 @@ public function getIterator()
 
     public function offsetExists($offset): bool
     {
-        return isset($this->array[$offset]);
+        return array_key_exists($offset, $this->array);
     }
 
     /**
@@ -171,7 +172,7 @@ public function find($value)
      */
     public function first()
     {
-        if (!isset($this->array[0])) {
+        if (!array_key_exists(0, $this->array)) {
             throw new OutOfBoundsException('Cannot grab first element of an empty list');
         }
 

src/Types/CypherMap.php

@@ -13,6 +13,7 @@
 
 namespace Laudis\Neo4j\Types;
 
+use function array_key_exists;
 use function array_key_first;
 use function array_key_last;
 use function array_keys;
@@ -106,7 +107,7 @@ public function getIterator()
      */
     public function offsetExists($offset): bool
     {
-        return isset($this->map[$offset]);
+        return array_key_exists($offset, $this->map);
     }
 
     /**
@@ -174,7 +175,7 @@ public function skip(int $position): ?Pair
     {
         $keys = $this->keys();
 
-        if (isset($keys[$position])) {
+        if (array_key_exists($position, $keys)) {
             $key = $keys[$position];
 
             return new Pair($key, $this->map[$key]);
@@ -208,7 +209,7 @@ public function intersect(iterable $map): CypherMap
     {
         $tbr = [];
         foreach ($map as $key => $value) {
-            if (isset($this->map[$key])) {
+            if (array_key_exists($key, $this->map)) {
                 $tbr[$key] = $this->map[$key];
             }
         }
@@ -226,7 +227,7 @@ public function diff($map): CypherMap
         $tbr = $this->map;
         /** @psalm-suppress UnusedForeachValue */
         foreach ($map as $key => $value) {
-            if (isset($tbr[$key])) {
+            if (array_key_exists($key, $tbr)) {
                 unset($tbr[$key]);
             }
         }
@@ -236,7 +237,7 @@ public function diff($map): CypherMap
 
     public function hasKey(string $key): bool
     {
-        return isset($this->map[$key]);
+        return array_key_exists($key, $this->map);
     }
 
     /**
@@ -285,7 +286,7 @@ public function get(string $key, $default = null)
             return $this->map[$key] ?? $default;
         }
 
-        if (!isset($this->map[$key])) {
+        if (!array_key_exists($key, $this->map)) {
             throw new OutOfBoundsException();
         }
 
@@ -446,14 +447,14 @@ public function xor(iterable $map): CypherMap
     {
         $tbr = [];
         foreach ($map as $key => $value) {
-            if (!isset($this->map[$key])) {
+            if (!array_key_exists($key, $this->map)) {
                 $tbr[$key] = $value;
             }
         }
 
         $cypherMap = new self($map);
         foreach ($this->map as $key => $value) {
-            if (!isset($cypherMap->map[$key])) {
+            if (!array_key_exists($key, $cypherMap->map)) {
                 $tbr[$key] = $value;
             }
         }