refactor: Use paginated query to generate user access export csvs in SSO form (no-changelog) #22930
+218
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 10m 17s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
konstantintieber
requested review from
a team,
BGZStephen and
geemanjs
and removed request for
a team and
geemanjs
konstantintieber
deleted the
pay-4264-use-paginated-query-to-generate-user-role-csv-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🎥 Demo video: https://www.loom.com/share/fae831c5f2454256989cad929e227931
Introduces pagination through
takeandskiprequest parameters to get the list of users instead oftake: -1.If a user clicks on the second "csv download" button before the first one finishes, we no longer start another request "fetching users from scratch", but wait for the first one to complete and use that one.
Related Linear tickets, Github issues, and Community forum posts
closes PAY-4264
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)