Merge pull request #101 from amirhossein-fzl/improvment-even-number-rule-performance

[1.x] Improvment even number rule performance

Author: milwad-dev

src/Rules/ValidEvenNumber.php

@@ -11,6 +11,10 @@ class ValidEvenNumber implements Rule
      */
     public function passes($attribute, $value): bool
     {
+        if (! is_numeric($value)) {
+            return false;
+        }
+
         $number = strval($value);
         $number = explode('.', $number);
 

tests/Rules/ValidEvenNumberTest.php

@@ -62,4 +62,20 @@ public function check_float_number_is_not_even()
 
         $this->assertFalse($passes);
     }
+
+    /**
+     * Test non-numeric values.
+     *
+     * @test
+     *
+     * @return void
+     */
+    public function check_non_numeric_values()
+    {
+        $rules = ['even_number' => [new ValidEvenNumber]];
+        $data = ['even_number' => 'abc'];
+        $passes = $this->app['validator']->make($data, $rules)->passes();
+
+        $this->assertFalse($passes);
+    }
 }