Skip to content

Conversation

@mtfriesen
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

The internal ES needs to know our version information, so provide that via a simple script.

Testing

Do any existing tests cover this change? Are new tests needed?

N/A.

Documentation

Is there any documentation impact for this change?

N/A.

Installation

Is there any installer impact for this change?

N/A.

@mtfriesen mtfriesen requested a review from a team as a code owner November 19, 2025 19:11
@mtfriesen mtfriesen enabled auto-merge (squash) November 19, 2025 19:11
@guhetier
Copy link
Contributor

guhetier commented Nov 19, 2025

Is there a reason not to create a "version.json" file like ES was using previously?
Is it because the tag / version.json version info would mismatch?

@mtfriesen mtfriesen merged commit 7619386 into main Nov 19, 2025
63 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/version_helper branch November 19, 2025 20:07
@mtfriesen
Copy link
Contributor Author

Is there a reason not to create a "version.json" file like ES was using previously? Is it because the tag / version.json version info would mismatch?

XDP never used version.json - it had already created a native .props file before the ES repo was incarnated. The reason XDP didn't switch (aside from inertia) is the powershell script to parse version.json slows builds down dramatically, at least on dev boxes where starting powershell.exe is relatively expensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants