Skip to content

[BUG] connection creation logic doesn't properly handle connection types where the creation method has no parameters #117

@edkreuk

Description

@edkreuk

Bug Description

When creating a new connection for FabricDataPipelines with WorkspaceIdentity you will receive an error:

Statement:
!fab create .connections/CON_FMD_FABRIC_PIPELINES.Connection -P connectionDetails.type=FabricDataPipelines,connectionDetails.creationMethod=FabricDataPipelines.Actions,credentialDetails.type=WorkspaceIdentity.

Error:
Creating a new Connection...x create: [InvalidInput] Parameters are required for the connection creation method. Required parameters are: . Optional parameters are.

fabric-cli version

1.31

Python version

3.11

Operating System

Windows

CLI Mode

Command line mode

Authentication Method

Interactive browser login

Steps to Reproduce

Fabric Notebook:
%pip install ms-fabric-cli

token = notebookutils.credentials.getToken('pbi')
os.environ['FAB_TOKEN'] = token
os.environ['FAB_TOKEN_ONELAKE'] = token

!fab create .connections/CON_FMD_FABRIC_PIPELINES_1.Connection -P connectionDetails.type=FabricDataPipelines,connectionDetails.creationMethod=FabricDataPipelines.Actions,credentialDetails.type=WorkspaceIdentity

Error:
Error:
Creating a new Connection...x create: [InvalidInput] Parameters are required for the connection creation method. Required parameters are: . Optional parameters are.

Expected Behavior

That connection is created

Actual Behavior

Create connection fails

Additional Context

No response

Possible Solution

adding connectionDetails.parameters.dummy=x will temporaly solve the issue, thanks to @HasanAboShally

!fab create .connections/CON_FMD_FABRIC_PIPELINES_1.Connection -P connectionDetails.type=FabricDataPipelines,connectionDetails.creationMethod=FabricDataPipelines.Actions,connectionDetails.parameters.dummy=x,credentialDetails.type=WorkspaceIdentity

Metadata

Metadata

Assignees

Labels

needs triageThis is a new issue that needs to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions