-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: update conversion and packages #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated many runtime and dev dependency versions in Changes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/api/mupdf/convert-page.ts (1)
97-99: Centralize the default scale factor to avoid future driftThe workaround for the mupdf 1.26.4 tiling bug looks good, but the initial default and the log message duplicate the same ternary. If the threshold or defaults change in the future, they could get out of sync.
You can DRY this slightly and keep the log accurate:
- // Note: Avoid scale factor 3 exactly due to mupdf 1.26.4 rendering bug with tiling patterns - let scaleFactor = width >= 1600 ? 2 : 2.95; + // Note: Avoid scale factor 3 exactly due to mupdf 1.26.4 rendering bug with tiling patterns + const defaultScaleFactor = width >= 1600 ? 2 : 2.95; + let scaleFactor = defaultScaleFactor; @@ - console.log( - `Large document detected. Reduced scale factor from ${width >= 1600 ? 2 : 2.95} to ${scaleFactor}`, - ); + console.log( + `Large document detected. Reduced scale factor from ${defaultScaleFactor} to ${scaleFactor}`, + );Also applies to: 125-127
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(7 hunks)pages/api/mupdf/convert-page.ts(2 hunks)
🔇 Additional comments (1)
package.json (1)
23-176: Major dependency bumps may require behavioral changes—please validate call sites and toolingSeveral upgrades here are potentially breaking (e.g.,
@react-email/components,@react-email/render,react-email,@react-email/preview-server,@sindresorhus/slugify,@vercel/blob,@trivago/prettier-plugin-sort-imports, and the large jump inmupdf). Themupdfchange is partially covered by the new scale-factor workaround, but other APIs or behaviors may also have shifted.Recommend:
- Re-running the full test suite and type-checks.
- Manually verifying critical paths:
- Email rendering + preview flows.
- Any slug generation that relies on
@sindresorhus/slugify.- Blob storage usage via
@vercel/blob.- Formatting behavior after
prettier/ sort-imports plugin changes.- Double-checking each library’s changelog for migration notes.
Summary by CodeRabbit
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.