chore: drop unused adaptor hooks

Author: zxch3n

llms.md

@@ -278,7 +278,7 @@ The resolved room implements:
   to stay within limits.
 - On receiving `DocUpdate`/fragments, the client reassembles updates and passes
   them to `crdtAdaptor.applyUpdate`.
-- `Ack` messages invoke `crdtAdaptor.handleAck`/`handleUpdateStatus` if provided; non‑zero statuses indicate the update batch was rejected.
+- `Ack` messages are logged; non‑zero statuses indicate the update batch was rejected.
 
 ### 3.8 Ping/Pong Integration
 

packages/loro-adaptors/README.md

@@ -107,12 +107,12 @@ import { YjsAwarenessServerAdaptor } from "loro-adaptors/yjs";
 ## API
 
 - `loro-adaptors/loro`
-  - `new LoroAdaptor(doc?: LoroDoc, config?: { onImportError?, onAck?, onRoomError?, onUpdateError? /* legacy alias for onAck */ })`
+  - `new LoroAdaptor(doc?: LoroDoc, config?: { onImportError? })`
   - `new LoroEphemeralAdaptor(store?: EphemeralStore)`
   - `new LoroPersistentStoreAdaptor(store?: EphemeralStore)`
-  - `new EloAdaptor(docOrConfig: LoroDoc | { getPrivateKey, ivFactory?, onDecryptError?, onAck?, onRoomError?, onUpdateError? /* legacy */ })`
+  - `new EloAdaptor(docOrConfig: LoroDoc | { getPrivateKey, ivFactory?, onDecryptError? })`
 - `loro-adaptors/flock`
-  - `new FlockAdaptor(flock: Flock, config?: { onImportError?, onAck?, onRoomError?, onUpdateError? /* legacy */ })`
+  - `new FlockAdaptor(flock: Flock, config?: { onImportError? })`
 - `loro-adaptors/yjs`
   - `new YjsAwarenessServerAdaptor()`
 

packages/loro-adaptors/src/elo-adaptor.ts

@@ -2,9 +2,6 @@ import { LoroDoc, VersionVector, decodeImportBlobMeta } from "loro-crdt";
 import {
   CrdtType,
   JoinResponseOk,
-  Ack,
-  RoomError,
-  UpdateStatusCode,
 } from "loro-protocol";
 import type { CrdtAdaptorContext, CrdtDocAdaptor } from "./types";
 import {
@@ -27,10 +24,6 @@ export interface EloAdaptorConfig {
     err: Error,
     meta: { kind: "delta" | "snapshot"; keyId: string }
   ) => void;
-  onAck?: (ack: Ack) => void;
-  onUpdateStatus?: (ack: Ack) => void;
-  onRoomError?: (err: RoomError) => void;
-  onUpdateError?: (ack: Ack) => void; // legacy naming
 }
 
 export class EloAdaptor implements CrdtDocAdaptor {
@@ -233,18 +226,6 @@ export class EloAdaptor implements CrdtDocAdaptor {
     }
   }
 
-  handleAck(ack: Ack): void {
-    this.config.onAck?.(ack);
-    if (ack.status !== UpdateStatusCode.Ok) {
-      this.config.onUpdateStatus?.(ack);
-      this.config.onUpdateError?.(ack);
-    }
-  }
-
-  handleRoomError(err: RoomError): void {
-    this.config.onRoomError?.(err);
-  }
-
   destroy(): void {
     if (this.destroyed) return;
     this.destroyed = true;

packages/loro-adaptors/src/flock-adaptor.ts

@@ -1,11 +1,7 @@
 import { Flock } from "@loro-dev/flock";
 import {
   CrdtType,
-  JoinError,
   JoinResponseOk,
-  Ack,
-  RoomError,
-  UpdateStatusCode,
 } from "loro-protocol";
 import type { CrdtAdaptorContext, CrdtDocAdaptor } from "./types";
 
@@ -99,10 +95,6 @@ function deserializeBundle(bytes: Uint8Array): FlockExportBundle {
 
 export interface FlockAdaptorConfig {
   onImportError?: (error: Error, data: Uint8Array[]) => void;
-  onAck?: (ack: Ack) => void;
-  onUpdateStatus?: (ack: Ack) => void;
-  onRoomError?: (err: RoomError) => void;
-  onUpdateError?: (status: Ack) => void; // legacy
 }
 
 /**
@@ -152,8 +144,6 @@ export class FlockAdaptor implements CrdtDocAdaptor {
     return compareVersions(this.flock.version(), remote);
   }
 
-  handleJoinErr?: (err: JoinError) => Promise<void>;
-
   setCtx(ctx: CrdtAdaptorContext): void {
     this.ctx = ctx;
     if (this.unsubscribe) {
@@ -233,18 +223,6 @@ export class FlockAdaptor implements CrdtDocAdaptor {
     }
   }
 
-  handleAck(ack: Ack): void {
-    this.config.onAck?.(ack);
-    if (ack.status !== UpdateStatusCode.Ok) {
-      this.config.onUpdateStatus?.(ack);
-      this.config.onUpdateError?.(ack);
-    }
-  }
-
-  handleRoomError(err: RoomError): void {
-    this.config.onRoomError?.(err);
-  }
-
   destroy(): void {
     if (this.destroyed) return;
     this.destroyed = true;

packages/loro-adaptors/src/loro-adaptor.ts

@@ -1,21 +1,12 @@
 import { LoroDoc, VersionVector } from "loro-crdt";
 import {
   CrdtType,
-  JoinError,
   JoinResponseOk,
-  Ack,
-  RoomError,
-  UpdateStatusCode,
 } from "loro-protocol";
 import type { CrdtAdaptorContext, CrdtDocAdaptor } from "./types";
 
 export interface LoroAdaptorConfig {
   onImportError?: (error: Error, data: Uint8Array[]) => void;
-  onAck?: (ack: Ack) => void;
-  onUpdateStatus?: (ack: Ack) => void;
-  onRoomError?: (err: RoomError) => void;
-  // Legacy hook
-  onUpdateError?: (status: Ack) => void;
 }
 
 export class LoroAdaptor implements CrdtDocAdaptor {
@@ -61,8 +52,6 @@ export class LoroAdaptor implements CrdtDocAdaptor {
     return this.doc.version().compare(vv) as 0 | 1 | -1 | undefined;
   }
 
-  handleJoinErr?: ((err: JoinError) => Promise<void>) | undefined;
-
   getDoc(): LoroDoc {
     return this.doc;
   }
@@ -132,6 +121,10 @@ export class LoroAdaptor implements CrdtDocAdaptor {
         // Pending updates may occur when concurrent changes happen
       }
     } catch (error) {
+      this.config.onImportError?.(
+        error instanceof Error ? error : new Error(String(error)),
+        updates
+      );
       this.ctx!.onImportError(
         error instanceof Error ? error : new Error(String(error)),
         updates
@@ -148,18 +141,6 @@ export class LoroAdaptor implements CrdtDocAdaptor {
     }
   }
 
-  handleAck(ack: Ack): void {
-    this.config.onAck?.(ack);
-    if (ack.status !== UpdateStatusCode.Ok) {
-      this.config.onUpdateStatus?.(ack);
-      this.config.onUpdateError?.(ack);
-    }
-  }
-
-  handleRoomError(err: RoomError): void {
-    this.config.onRoomError?.(err);
-  }
-
   destroy(): void {
     if (this.destroyed) return;
     this.destroyed = true;

packages/loro-adaptors/src/loro-ephemeral-adaptor.ts

@@ -22,8 +22,6 @@ export class LoroEphemeralAdaptor implements CrdtDocAdaptor {
     return 0 as const;
   }
 
-  handleJoinErr?: undefined;
-
   getStore(): EphemeralStore {
     return this.store;
   }

packages/loro-adaptors/src/loro-persistent-store-adaptor.ts

@@ -22,8 +22,6 @@ export class LoroPersistentStoreAdaptor implements CrdtDocAdaptor {
     return 0 as const;
   }
 
-  handleJoinErr?: undefined;
-
   getStore(): EphemeralStore {
     return this.store;
   }

packages/loro-adaptors/src/types.ts

@@ -1,10 +1,4 @@
-import {
-  CrdtType,
-  JoinResponseOk,
-  JoinError,
-  Ack,
-  RoomError,
-} from "loro-protocol";
+import { CrdtType, JoinResponseOk } from "loro-protocol";
 
 export interface CrdtDocAdaptor {
   crdtType: CrdtType;
@@ -45,16 +39,8 @@ export interface CrdtDocAdaptor {
   getAlternativeVersion?: (
     currentVersion: Uint8Array
   ) => Uint8Array | undefined;
-  /**
-   * Handle update status/acks with context-specific logic
-   * @param ack The ack details
-   */
-  handleAck?: (ack: Ack) => void;
-  handleUpdateStatus?: (ack: Ack) => void;
-  handleRoomError?: (err: RoomError) => void;
   // Legacy hook retained for compatibility
   handleUpdateError?: (error: unknown) => void;
-  handleJoinErr?: (err: JoinError) => Promise<void>;
   destroy: () => void;
 }
 

packages/loro-websocket/src/client/index.ts

@@ -808,9 +808,6 @@ export class LoroWebsocketClient {
     pending: PendingRoom,
     roomId: string
   ) {
-    // First, let adaptor handle the error for custom logic
-    await pending.adaptor.handleJoinErr?.(msg);
-
     if (msg.code === JoinErrorCode.VersionUnknown) {
       // Try alternative version format
       const currentVersion = pending.adaptor.getVersion();
@@ -1485,22 +1482,12 @@ class LoroWebsocketClientRoomImpl
   }
 
   handleAck(ack: Ack) {
-    // Prefer dedicated handlers; otherwise warn when a non-ok status arrives.
-    if (this.crdtAdaptor.handleAck) {
-      this.crdtAdaptor.handleAck(ack);
-      return;
-    }
-    if (this.crdtAdaptor.handleUpdateStatus) {
-      this.crdtAdaptor.handleUpdateStatus(ack);
-      return;
-    }
     if (ack.status !== UpdateStatusCode.Ok) {
       console.warn(`Ack status ${ack.status} for ${this.crdtType}:${this.roomId} (ref ${ack.refId})`);
     }
   }
 
   handleRoomError(error: RoomError) {
-    this.crdtAdaptor.handleRoomError?.(error);
     // Only mark destroyed for terminal errors; rejoin-suggested errors keep the room alive for retry.
     if (error.code !== RoomErrorCode.RejoinSuggested) {
       this.destroyed = true;