Skip to content

Remove crossorigin from preload hints for same-origin vendor assets #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonchurch merged 2 commits into from
Dec 7, 2025
Merged

Remove crossorigin from preload hints for same-origin vendor assets #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
406c845
Remove crossorigin from preload hints for same-origin vendor assets
jonchurch Dec 5, 2025
56756a3
remove jsdelivr hint, we dont use it at all currently
jonchurch Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions _headers
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ csp:
hints:
all: [
'</sw.js>; rel=serviceworker',
'<https://cdn.jsdelivr.net/>; rel=preconnect; pr=1.0; crossorigin',
Copy link
Member Author

@jonchurch jonchurch Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just dont use anything from jsdeliver directly anymore, we serve under our own origin

'<//cdn.carbonads.com/>; rel=dns-prefetch; pr=0.25',
'<//srv.carbonads.net/>; rel=dns-prefetch; pr=0.25'
]
Expand Down Expand Up @@ -92,7 +91,7 @@ Add resource hints for site-wide css.
Add resource hints for site-wide vendor css.
{% endcomment %}
{% for res in site.vendor.css %}
{% capture hint %}<{{ res.href }}>; rel=preload; as=style; pr=1.0; crossorigin{% endcapture %}
{% capture hint %}<{{ res.href }}>; rel=preload; as=style; pr=1.0{% endcapture %}
{% assign all = all | push:hint %}
{% endfor %}

Expand All @@ -103,7 +102,7 @@ Add resource hints for site-wide font faces.
{% for style in family[1] %}
{% for href in style[1] %}
{% if href contains '.woff2' %}
{% capture hint %}<{{ href }}>; rel=preload; as=font; pr=1.0; crossorigin{% endcapture %}
{% capture hint %}<{{ href }}>; rel=preload; as=font; pr=1.0{% endcapture %}
{% assign all = all | push:hint %}
{% endif %}
{% endfor %}
Expand Down Expand Up @@ -146,7 +145,7 @@ Add resource hints for docs js.
Add resource hints for docs vendor js.
{% endcomment %}
{% for res in site.vendor.js %}
{% capture hint %}<{{ res.href }}>; rel=preload; as=script; pr=1.0; crossorigin{% endcapture %}
{% capture hint %}<{{ res.href }}>; rel=preload; as=script; pr=1.0{% endcapture %}
{% assign docs = docs | push:hint %}
{% endfor %}

Expand Down Expand Up @@ -178,7 +177,7 @@ Add link header for doc pages.

{% for res in site.builds %}
/docs/{{ res[0] }}*
Link: <{{ res[1].href }}>; rel=preload; as=script; pr=1.0; crossorigin
Link: <{{ res[1].href }}>; rel=preload; as=script; pr=1.0
{% endfor %}

{% comment %}
Expand Down
4 changes: 4 additions & 0 deletions assets/js/boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
function addStyleSheet(res) {
var link = document.createElement('link')

// Note: crossOrigin is only needed for cross-origin requests with SRI.
// Since vendor assets are now served from same origin (/vendor/...),
// this condition won't match and crossOrigin won't be set - which is correct.
// If loading from external CDNs again, this enables CORS for SRI verification.
if (res.integrity &&
res.href.slice(0, 6) === 'https:') {
link.crossOrigin = 'anonymous'
Expand Down