logicalTypes: fix alternative encoding for decimal types #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternative is an explicit codec decimal type, additionally, this only worked for a small subset of values that were both valid native and valid binary encoding. Since we want to stay in the native value space, we just need to convert from native primative to native logical type. In order to do this we just do an encode/decode step for decimal logical types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative is an explicit codec decimal type, additionally, this
only worked for a small subset of values that were both valid native
and valid binary encoding. Since we want to stay in the native value
space, we just need to convert from native primative to native logical
type. In order to do this we just do an encode/decode step for decimal
logical types.