Merge pull request #4453 from paralin/fix-nil-reference

AkihiroSuda · web-flow · commit 598e0e826daf · 2025-12-16T11:14:15.000+09:00
fix: nil pointer dereference panic in shellAction
diff --git a/cmd/limactl/shell.go b/cmd/limactl/shell.go
@@ -94,6 +94,12 @@ func shellAction(cmd *cobra.Command, args []string) error {
 		}
 		return err
 	}
+	if inst.Config == nil {
+		if len(inst.Errors) > 0 {
+			return fmt.Errorf("instance %q has configuration errors: %w", instName, errors.Join(inst.Errors...))
+		}
+		return fmt.Errorf("instance %q has no configuration", instName)
+	}
 	if inst.Status == limatype.StatusStopped {
 		startNow, err := flags.GetBool("start")
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,12 @@ func shellAction(cmd *cobra.Command, args []string) error {`
`94`	`94`	`}`
`95`	`95`	`return err`
`96`	`96`	`}`
	`97`	`+ if inst.Config == nil {`
	`98`	`+ if len(inst.Errors) > 0 {`
	`99`	`+ return fmt.Errorf("instance %q has configuration errors: %w", instName, errors.Join(inst.Errors...))`
	`100`	`+ }`
	`101`	`+ return fmt.Errorf("instance %q has no configuration", instName)`
	`102`	`+ }`
`97`	`103`	`if inst.Status == limatype.StatusStopped {`
`98`	`104`	`startNow, err := flags.GetBool("start")`
`99`	`105`	`if err != nil {`