You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* fix: include requirements files in python sdist (#12330)
The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.
Signed-off-by: Doug Hellmann <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
(cherry picked from commit de73b6f)
* chore: release 2.14.5
automate requirements updates
Signed-off-by: Humair Khan <[email protected]>
---------
Signed-off-by: Humair Khan <[email protected]>
Co-authored-by: Doug Hellmann <[email protected]>
Once done you should see a diff in `requirements.txt`. Confirm the changes.
266
+
267
+
Update the SDK version in `version.py` and `readthedocs` `versions.json`, example PR [here](https://github.com/kubeflow/pipelines/pull/11715/files).
268
+
269
+
```bash
270
+
git checkout -b release-X.Y
271
+
pip3 install twine --user
272
+
cd sdk
273
+
make python
274
+
cd python
275
+
twine check dist/*
276
+
twine upload dist/*
277
+
```
278
+
279
+
!!! The file name must contain the version. See <https://github.com/kubeflow/pipelines/issues/1292>
280
+
281
+
**Update `kfp` Readthedocs**
256
282
257
283
* Create a GitHub release for KFP SDK release. [Here's an example](https://github.com/kubeflow/pipelines/releases/tag/sdk-2.14.1) reference for a template.
258
284
* When creating a release create a new tag `sdk-x.y.z`
@@ -264,6 +290,19 @@ When performing these releases, you should adhere to the order presented below.
264
290
265
291
1. Release `kfp-kubernetes` Python packages to PyPI.
266
292
293
+
Note that if this `kfp-kubenretes` release depends on a new version of `kfp` or `kfp-pipeline-spec`, ensure
294
+
those packages have their versions updated, and you have built them in twine.
295
+
Then update `kubernetes_platform/python/requirements.in` file, ensure these package's lower-bound versions are accurate.
296
+
Once done, you can run the following command to update the requirements:
297
+
298
+
```bash
299
+
cd kubernetes_platform/python
300
+
# Note if the dependent packages have already been released use the following command:
Update the KFP Kubernetes SDK version in `__init__.py` and `readthedocs` `versions.json`, example PR [here](https://github.com/kubeflow/pipelines/pull/11380).
268
307
269
308
```bash
@@ -287,7 +326,8 @@ When performing these releases, you should adhere to the order presented below.
287
326
> Note that kfp-kubernetes package has a separate readthedocs site and requires that a new branch be pushed for readthedocs to be able to host multiple pages from the same repo.
288
327
> Every new patch version for this package requires us to create a new release branch purely for readthedocs purposes. However always cut this branch from the `release-X.Y` branch.
289
328
290
-
** Update Readthedocs **
329
+
**Update `kfp-kubernetes` Readthedocs**
330
+
291
331
Once the branch is updated, you need to add this version to readthedocs. Follow these steps:
292
332
293
333
* Navigate to the package section on the readthedocs website [here](https://app.readthedocs.org/projects/kfp-kubernetes/).
@@ -297,18 +337,7 @@ Once the branch is updated, you need to add this version to readthedocs. Follow
297
337
* Go to Settings
298
338
* Set this version as the default version.
299
339
* Click Save
300
-
* Click "View Docs" to navigate to the docs page and ensure the new version shows up as the default.
301
-
302
-
1. Release `kfp-server-api` Python packages to PyPI.
303
-
304
-
```bash
305
-
git checkout $BRANCH
306
-
git pull upstream $BRANCH
307
-
cd backend/api/v2beta1/python_http_client
308
-
rm -r dist
309
-
python3 setup.py --quiet sdist
310
-
python3 -m twine upload dist/*
311
-
```
340
+
* Click "View Docs" to navigate to the docs page and ensure the new version shows up as the default.
0 commit comments