Merge pull request #207 Get values before validating

mymarche · web-flow · commit 4091b9375433 · 2024-11-19T11:20:00.000+03:00
Get values before validating
diff --git a/src/main/java/io/jenkins/plugins/restlistparam/RestListParameterDefinition.java b/src/main/java/io/jenkins/plugins/restlistparam/RestListParameterDefinition.java
@@ -231,7 +231,6 @@ public ParameterDefinition copyWithDefaultValue(final ParameterValue defaultValu
   public ParameterValue createValue(final String value) {
     RestListParameterValue parameterValue = new RestListParameterValue(getName(), value, getDescription());
 
-    getValues();
     checkValue(parameterValue);
     return parameterValue;
   }
@@ -242,7 +241,6 @@ public ParameterValue createValue(final StaplerRequest req,
   {
     RestListParameterValue value = req.bindJSON(RestListParameterValue.class, jo);
 
-    getValues();
     checkValue(value);
     return value;
   }
@@ -258,7 +256,7 @@ public boolean isValid(ParameterValue value) {
     if(value == null || value.getValue() == null) {
       return false;
     }
-
+    getValues();
     return values.stream()
       .map(ValueItem::getValue)
       .filter(Objects::nonNull)

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,6 @@ public ParameterDefinition copyWithDefaultValue(final ParameterValue defaultValu`
`231`	`231`	`public ParameterValue createValue(final String value) {`
`232`	`232`	`RestListParameterValue parameterValue = new RestListParameterValue(getName(), value, getDescription());`
`233`	`233`
`234`		`- getValues();`
`235`	`234`	`checkValue(parameterValue);`
`236`	`235`	`return parameterValue;`
`237`	`236`	`}`
`@@ -242,7 +241,6 @@ public ParameterValue createValue(final StaplerRequest req,`
`242`	`241`	`{`
`243`	`242`	`RestListParameterValue value = req.bindJSON(RestListParameterValue.class, jo);`
`244`	`243`
`245`		`- getValues();`
`246`	`244`	`checkValue(value);`
`247`	`245`	`return value;`
`248`	`246`	`}`
`@@ -258,7 +256,7 @@ public boolean isValid(ParameterValue value) {`
`258`	`256`	`if(value == null \|\| value.getValue() == null) {`
`259`	`257`	`return false;`
`260`	`258`	`}`
`261`		`-`
	`259`	`+ getValues();`
`262`	`260`	`return values.stream()`
`263`	`261`	`.map(ValueItem::getValue)`
`264`	`262`	`.filter(Objects::nonNull)`