Several improvements to RecordSet handling. #1992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When looking up .RefCol or .RefListCol on an empty reference list, return and empty RecordSet. This allows e.g. Table.lookupRecords(...).RefCol.Name to be used even when lookupRecords() returns an empty set. This previously didn't work. 2. When looking up .RefListCol on a reference list, return a merged RecordSet. This already worked when e.g. Table.lookupRecords(...).RefListCol was set as the value for a RefList column, but now Table.lookupRecords(...).RefListCol.Name is also allowed. 3. Allow RefList to get set to a single compatible reference, turning it into a list. Resolves #1987 and #1985.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
.RefColor.RefListColon an empty reference list, return and empty RecordSet. This allows e.g.Table.lookupRecords(...).RefCol.Nameto be used even when lookupRecords() returns an empty set. This previously didn't work..RefListColon a reference list, return a mergedRecordSet. This already worked when e.g.Table.lookupRecords(...).RefListColwas set as the value for a RefList column, but nowTable.lookupRecords(...).RefListCol.Nameis similarly allowed.Related issues
Resolves #1987 and #1985, which include some of the scenarios being addressed.
Has this been tested?