internal/lsp: handle out of range panic in template parsing

Fixes golang/vscode-go#1548

Change-Id: I95911a417cecc514151e75a60253ef119803885e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/326089
Trust: Rebecca Stambler <[email protected]>
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Go Bot <[email protected]>
(cherry picked from commit 4e58f8f)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/326109
Reviewed-by: Peter Weinberger <[email protected]>

Author: stamblerre

internal/lsp/template/parse.go

@@ -86,6 +86,7 @@ func parseBuffer(buf []byte) *Parsed {
 	ans := &Parsed{
 		buf:   buf,
 		check: -1,
+		nls:   []int{-1},
 	}
 	if len(buf) == 0 {
 		ans.ParseErr = errors.New("empty buffer")
@@ -103,7 +104,6 @@ func parseBuffer(buf []byte) *Parsed {
 	}
 	// at the cost of complexity we could fold this into the allAscii loop
 	ans.lines = bytes.Split(buf, []byte{'\n'})
-	ans.nls = []int{-1}
 	for i, p := range ans.buf {
 		if p == '\n' {
 			ans.nls = append(ans.nls, i)