[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6

b261fe9 go/tools: add vet check for direct comparion of reflect.Values
e78b40c internal/lsp: switch to 'go get -u ./...' for transitive upgrades
3ac76b8 gopls/internal/coverage: better error messages and output
c602466 Revert "internal/lsp/cache: disable GOPACKAGESDRIVER"
35a9159 go/internal/gcimporter: ensure that imported floats are of float kind
5d33438 go/internal/gcimporter: merge go1.11 tests back into gcimporter_test.go
11c3f83 internal/lsp/source: fix Highlight for std and 3rd-party packages
8c34cc9 internal/lsp/cache: fix race condition in snapshot's initializedErr
0deaffd gopls/internal/regtest: re-enable the gc_details regtest for -short
af36406 internal/lsp/source: respond with the underlying type to Type Definition requests for composite types
682c7e6 godoc/static: link to golang.org for content moved out of Go root
ca627f8 internal/lsp/semantic: fix some type definitions
0459589 internal/lsp/protocol/typescript: small cleanups and add tsconfig.json
b0e994d internal/jsonrpc2_v2: move the idle timeout handling out of the server
9553575 internal/lsp: remove unnecessary call to WorkspacePackages in mod tidy
769264c internal/lsp/source: fix docs for fields of anonymous structs/interfaces
cb7d599 internal/lsp/source: skip blank identifiers during the function extraction
94a1942 internal/lsp/completion: move postfix completions behind option
09058ab internal/lsp/source/completion: add postfix snippet completions
2c039f7 internal/event/label: prevent unsafe get of non-string
4c8e4a8 go/analysis/passes/inspect: fix typo in comment
63ea654 internal/lsp: hold the gc details lock when storing diagnostics
7f6d50e internal/lsp/source: fix hover and completion with dot imports
b3556f0 internal/lsp: remove some unused parameters, mostly in the cache package
09a00c1 internal/lsp: fix support for SourceFixAll code actions
877f9c4 internal/jsonrpc2_v2: an updated jsonrpc2 library
52cb772 gopls: upgrade mvdan.cc/gofumpt to v0.1.1
a1191f3 gopls: upgrade honnef.co/go/tools to v0.1.3
d8aeb16 internal/lsp: add defaultLibrary mod for basic types
aa0c723 internal/lsp/cache: get control of reloadOrphanedFiles
d7a25ad gopls/integration: remove obsolete code
9bdb419 gopls/internal: add coverage command to compute test coverage
d2e11a2 present: don't drop commands that immediately follow text
695b167 cmd/present2md: allow comments to be retained in translated document
a14ff98 present: retain complete caption command when parsing captions
1aac171 Update emacs.md - add .dir-locals.el example
2c4a886 internal/lsp: remove module diagnostics from code actions
9b614f5 internal/lsp/cache: tolerate analysis panics better
9e9211a gopls/internal/regtest: fix race when printing regtest state on falure
6d45e3d internal/lsp: add a temp workspace per folder, and a helper command
e409f12 internal/lsp: add snippet completion for t.Fatal errs
8e4f4c8 godoc: delete GoogleCN logic
44abc2a internal/lsp: only load by view when there are no go.mod files

Change-Id: Ie5d628f640a8edaeb41c4cdf30aafefbc892ec7c

Author: stamblerre

cmd/godoc/main.go

@@ -192,8 +192,10 @@ func main() {
 	}
 	if *templateDir != "" {
 		fs.Bind("/lib/godoc", vfs.OS(*templateDir), "/", vfs.BindBefore)
+		fs.Bind("/favicon.ico", vfs.OS(*templateDir), "/favicon.ico", vfs.BindReplace)
 	} else {
 		fs.Bind("/lib/godoc", mapfs.New(static.Files), "/", vfs.BindReplace)
+		fs.Bind("/favicon.ico", mapfs.New(static.Files), "/favicon.ico", vfs.BindReplace)
 	}
 
 	// Get the GOMOD value, use it to determine if godoc is being invoked in module mode.

cmd/present2md/main.go

@@ -93,6 +93,11 @@ func convert(r io.Reader, file string, writeBack bool) error {
 		return fmt.Errorf("%v: already markdown", file)
 	}
 
+	// Convert all comments before parsing the document.
+	// The '//' comment is treated as normal text and so
+	// is passed through the translation unaltered.
+	data = bytes.Replace(data, []byte("\n#"), []byte("\n//"), -1)
+
 	doc, err := present.Parse(bytes.NewReader(data), file, 0)
 	if err != nil {
 		return err

go/analysis/passes/inspect/inspect.go

@@ -3,8 +3,8 @@
 // license that can be found in the LICENSE file.
 
 // Package inspect defines an Analyzer that provides an AST inspector
-// (golang.org/x/tools/go/ast/inspect.Inspect) for the syntax trees of a
-// package. It is only a building block for other analyzers.
+// (golang.org/x/tools/go/ast/inspector.Inspector) for the syntax trees
+// of a package. It is only a building block for other analyzers.
 //
 // Example of use in another analysis:
 //

go/analysis/passes/reflectvaluecompare/reflectvaluecompare.go

@@ -0,0 +1,99 @@
+// Copyright 2021 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Package reflectvaluecompare defines an Analyzer that checks for accidentally
+// using == or reflect.DeepEqual to compare reflect.Value values.
+// See issues 43993 and 18871.
+package reflectvaluecompare
+
+import (
+	"go/ast"
+	"go/token"
+	"go/types"
+
+	"golang.org/x/tools/go/analysis"
+	"golang.org/x/tools/go/analysis/passes/inspect"
+	"golang.org/x/tools/go/ast/inspector"
+	"golang.org/x/tools/go/types/typeutil"
+)
+
+const Doc = `check for comparing reflect.Value values with == or reflect.DeepEqual
+
+The reflectvaluecompare checker looks for expressions of the form:
+
+    v1 == v2
+    v1 != v2
+    reflect.DeepEqual(v1, v2)
+
+where v1 or v2 are reflect.Values. Comparing reflect.Values directly
+is almost certainly not correct, as it compares the reflect package's
+internal representation, not the underlying value.
+Likely what is intended is:
+
+    v1.Interface() == v2.Interface()
+    v1.Interface() != v2.Interface()
+    reflect.DeepEqual(v1.Interface(), v2.Interface())
+`
+
+var Analyzer = &analysis.Analyzer{
+	Name:     "reflectvaluecompare",
+	Doc:      Doc,
+	Requires: []*analysis.Analyzer{inspect.Analyzer},
+	Run:      run,
+}
+
+func run(pass *analysis.Pass) (interface{}, error) {
+	inspect := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
+
+	nodeFilter := []ast.Node{
+		(*ast.BinaryExpr)(nil),
+		(*ast.CallExpr)(nil),
+	}
+	inspect.Preorder(nodeFilter, func(n ast.Node) {
+		switch n := n.(type) {
+		case *ast.BinaryExpr:
+			if n.Op != token.EQL && n.Op != token.NEQ {
+				return
+			}
+			if isReflectValue(pass, n.X) || isReflectValue(pass, n.Y) {
+				if n.Op == token.EQL {
+					pass.ReportRangef(n, "avoid using == with reflect.Value")
+				} else {
+					pass.ReportRangef(n, "avoid using != with reflect.Value")
+				}
+			}
+		case *ast.CallExpr:
+			fn, ok := typeutil.Callee(pass.TypesInfo, n).(*types.Func)
+			if !ok {
+				return
+			}
+			if fn.FullName() == "reflect.DeepEqual" && (isReflectValue(pass, n.Args[0]) || isReflectValue(pass, n.Args[1])) {
+				pass.ReportRangef(n, "avoid using reflect.DeepEqual with reflect.Value")
+			}
+		}
+	})
+	return nil, nil
+}
+
+// isReflectValue reports whether the type of e is reflect.Value.
+func isReflectValue(pass *analysis.Pass, e ast.Expr) bool {
+	tv, ok := pass.TypesInfo.Types[e]
+	if !ok { // no type info, something else is wrong
+		return false
+	}
+	// See if the type is reflect.Value
+	named, ok := tv.Type.(*types.Named)
+	if !ok {
+		return false
+	}
+	if obj := named.Obj(); obj == nil || obj.Pkg() == nil || obj.Pkg().Path() != "reflect" || obj.Name() != "Value" {
+		return false
+	}
+	if _, ok := e.(*ast.CompositeLit); ok {
+		// This is reflect.Value{}. Don't treat that as an error.
+		// Users should probably use x.IsValid() rather than x == reflect.Value{}, but the latter isn't wrong.
+		return false
+	}
+	return true
+}

go/analysis/passes/reflectvaluecompare/reflectvaluecompare_test.go

@@ -0,0 +1,17 @@
+// Copyright 2021 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package reflectvaluecompare_test
+
+import (
+	"testing"
+
+	"golang.org/x/tools/go/analysis/analysistest"
+	"golang.org/x/tools/go/analysis/passes/reflectvaluecompare"
+)
+
+func TestReflectValueCompare(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, reflectvaluecompare.Analyzer, "a")
+}

go/analysis/passes/reflectvaluecompare/testdata/src/a/a.go

@@ -0,0 +1,51 @@
+// Copyright 2021 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// This file contains tests for the reflectvaluecompare checker.
+
+package a
+
+import (
+	"reflect"
+)
+
+func f() {
+	var x, y reflect.Value
+	var a, b interface{}
+	_ = x == y // want `avoid using == with reflect.Value`
+	_ = x == a // want `avoid using == with reflect.Value`
+	_ = a == x // want `avoid using == with reflect.Value`
+	_ = a == b
+
+	// Comparing to reflect.Value{} is ok.
+	_ = a == reflect.Value{}
+	_ = reflect.Value{} == a
+	_ = reflect.Value{} == reflect.Value{}
+}
+func g() {
+	var x, y reflect.Value
+	var a, b interface{}
+	_ = x != y // want `avoid using != with reflect.Value`
+	_ = x != a // want `avoid using != with reflect.Value`
+	_ = a != x // want `avoid using != with reflect.Value`
+	_ = a != b
+
+	// Comparing to reflect.Value{} is ok.
+	_ = a != reflect.Value{}
+	_ = reflect.Value{} != a
+	_ = reflect.Value{} != reflect.Value{}
+}
+func h() {
+	var x, y reflect.Value
+	var a, b interface{}
+	reflect.DeepEqual(x, y) // want `avoid using reflect.DeepEqual with reflect.Value`
+	reflect.DeepEqual(x, a) // want `avoid using reflect.DeepEqual with reflect.Value`
+	reflect.DeepEqual(a, x) // want `avoid using reflect.DeepEqual with reflect.Value`
+	reflect.DeepEqual(a, b)
+
+	// Comparing to reflect.Value{} is ok.
+	reflect.DeepEqual(reflect.Value{}, a)
+	reflect.DeepEqual(a, reflect.Value{})
+	reflect.DeepEqual(reflect.Value{}, reflect.Value{})
+}