Skip to content

Commit 6e618cd

Browse files
dsnetgopherbot
authored andcommitted
encoding/json: use zstd compressed testdata
There is a non-public zstd decoder in the stdlib (CL 473356) and also zstd compressed testdata already present. Delete testdata/code.json.gz and instead use internal/jsontest/testdata/golang_source.json.zst, which has exactly the same content: $ cat internal/jsontest/testdata/golang_source.json.zst | zstd -d | sha1sum 3f70b6fd429f4aba3e8e1c3e5a294c8f2e219a6e - $ cat testdata/code.json.gz | zstd -d | sha1sum 3f70b6fd429f4aba3e8e1c3e5a294c8f2e219a6e - This will reduce the size of the final Go release by 118KB. Updates #71845 Change-Id: I6da2df27bd260befc0a44c6bc0255365be0a5b0f Reviewed-on: https://go-review.googlesource.com/c/go/+/525516 Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Bypass: Damien Neil <[email protected]>
1 parent fcb9850 commit 6e618cd

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/encoding/json/bench_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ package json
1414

1515
import (
1616
"bytes"
17-
"compress/gzip"
1817
"fmt"
1918
"internal/testenv"
19+
"internal/zstd"
2020
"io"
2121
"os"
2222
"reflect"
@@ -46,15 +46,12 @@ var codeJSON []byte
4646
var codeStruct codeResponse
4747

4848
func codeInit() {
49-
f, err := os.Open("testdata/code.json.gz")
49+
f, err := os.Open("internal/jsontest/testdata/golang_source.json.zst")
5050
if err != nil {
5151
panic(err)
5252
}
5353
defer f.Close()
54-
gz, err := gzip.NewReader(f)
55-
if err != nil {
56-
panic(err)
57-
}
54+
gz := zstd.NewReader(f)
5855
data, err := io.ReadAll(gz)
5956
if err != nil {
6057
panic(err)
-118 KB
Binary file not shown.

0 commit comments

Comments
 (0)