Skip to content

Conversation

@gwr-de
Copy link
Contributor

@gwr-de gwr-de commented Nov 22, 2025

While it may not yet be completely perfect, I have carefully checked this with ChatGPT 5.1 to be "modern, idiomatic Danish." I hope this to be a good start for having Danish enter the set of Pluto-supported languages. Velbekomme! 🇩🇰

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/gwr69/Pluto.jl", rev="lang-dansk")
julia> using Pluto

@fonsp
Copy link
Owner

fonsp commented Dec 1, 2025

Hey @gwr-de, mange tak! Some comments:

I changed the name from dansk_da to dansk_dk, based on some online results. This is correct, right?

I added the JS code to enable Danish in the language picker. That means that you can try Pluto with this PR, and see what the localization looks like in action! To do so, you just Pkg.dev(..path to your clone of Pluto..) and then run Pluto as usual. It will print a message "Looks like you are developing Pluto" in the terminal where you launched Pluto. Then you can pick Danish in the language picker.

Can you try it out and let me know what you think? Are there any changes (like layout) that you still want to make?

Thanks again!

@gwr-de
Copy link
Contributor Author

gwr-de commented Dec 1, 2025

Hey @gwr-de, mange tak!

Det var så lidt.

I changed the name from dansk_da to dansk_dk, based on some online results. This is correct, right?

Indeed, that's probably the next best thing to da_DK.json as danish_da is giving the same information twice...

I will try it out and report back.

EDIT

I would still recommend to use international standardized names for languages (e.g., IETF BCP 47) and (if needed/useful) countries (e.g., ISO 3166-1 alpha-2) to name files—not the language name in the language, given that some languages bring their own alphabets?

@gwr-de
Copy link
Contributor Author

gwr-de commented Dec 2, 2025

Thanks for renaming to danish_dk.json.

Just as a suggestion for consistent naming: One might well argue that with regard to UI translations, there is really only one main variant of German (de) or even Dutch (nl), while country- or regional variants might become relevant for Portuguese (pt-PR and pt-BR) or English (en-US vs. en-UK) or even French (fr-FR vs. fr-CA).

Danish pretty squarely is like German here imho (e.g., there is Faroese fo next to Danish) and there is no need to add the country, e.g., da.json could sit right next to de.json and nl.json.

@fonsp
Copy link
Owner

fonsp commented Dec 3, 2025

If you want to make that change for danish then that's fine!

For dutch this is not true (e.g. standard belgian dutch is different and there are more variations), for german the localizer decided to add the region for similar reasons.

@gwr-de
Copy link
Contributor Author

gwr-de commented Dec 3, 2025

I did some testing using Pkg.dev and from my point of view this is now good to go.

@fonsp
Copy link
Owner

fonsp commented Dec 3, 2025

Awesome, thanks so much!!

@fonsp fonsp merged commit 9162962 into fonsp:main Dec 3, 2025
6 checks passed
@gwr-de gwr-de deleted the lang-dansk branch December 3, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants