Check for disk space before installing/unpacking

[Stoney3K]

Installer Version

3.4.3

Description

When installing a package currently the installer is oblivious about the available disk space and it will simply error out if the drive is full when it is in the process of either downloading or unpacking. If the process exits all files are deleted and you have to re-download everything which can be very annoying, particularly when it's a space-hogging package.

It would be great if the installer could check how much disk space is needed before starting the installation process and warn the user if there is not enough space to complete it.

References (optional)

No response

Additional info (optional)

No response

Discord Username (optional)

No response

[FoxtrotSierra6829]

The installer does check for the available disk space before installation and the user is being informed about this in a modal.

Could you provide more information for your specific issue?

[Stoney3K]

It may do so on downloading, but it does not take into account the required disk space for unpacking afterwards. Either that, or it only counts the total (installation) space and it doesn't add the temporary space required for downloading.

I tried to download the FSLTL base model package with less than 40GB of available space and it errored out with a 'no space on device' halfway through the unpacking process.

[FoxtrotSierra6829]

It should ask for 47GB of free space on initial install. Do you see this modal when you initiate the installation?
The disk space required is the disk space for the download and the unpacking, not the occupied space when installed.

[FoxtrotSierra6829]

In case you already have the addon installed and are intending to update it, please paste your /fsltl-traffic-base/install.json here.

[Stoney3K]

I deliberately uninstalled the package to check if that was the case. I got no modal asking me about disk space.

Perhaps I checked the "Don't show this again" when installing the A320 and it was retained across other packages, but that would mean the space check is also done in this modal and not before it.

There is also no way to cancel the "Don't show this again" to get the modal to show back up.

[FoxtrotSierra6829]

I'll check this

[FoxtrotSierra6829]

No, the logic is it is shown if it's not disabled or if there is not enough space. The only exception is if it is not possible to calculate the required space or the free space.
Can you try if it shows for another addon?

[Stoney3K]

It does not show a modal for any other package. Using installer version 3.4.3.

[FoxtrotSierra6829]

Do you use the setting separate location for temporary folders?

[Stoney3K]

No, that's still on the default setting of being off.

[FoxtrotSierra6829]

What is your OS, and what is the partition where your install directory is located formatted as?

[FoxtrotSierra6829]

And please check %appdata%\FlyByWire Installer\config.json for entries of disableAddonDiskSpaceModal, alternatively reset the settings

[Stoney3K]

OS is Windows 10 Pro 22H2 (build 19045.5371), partition is an M.2 SSD formatted as NTFS.

[Stoney3K]

In the config:

"disableAddonDiskSpaceModal": {},

Deleting the entry has no effect.

[FoxtrotSierra6829]

Hmm, that's a very interesting one. If it was disabled, it'd have entries in the object for each affected addon. My guess is it somehow has issues to check your available storage, but I am unsure why.