refactor: simplify error handling in res.write tests

Signed-off-by: Sebastian Beltran <[email protected]>

Author: bjohansebas

index.js

@@ -70,8 +70,6 @@ function compression (options) {
     threshold = 1024
   }
 
-  function noop () { }
-
   return function compression (req, res, next) {
     var ended = false
     var length
@@ -92,25 +90,6 @@ function compression (options) {
     // proxy
 
     res.write = function write (chunk, encoding, callback) {
-      if (chunk === null) {
-        // throw ERR_STREAM_NULL_VALUES
-        return _write.call(this, chunk, encoding, callback)
-      } else if (typeof chunk === 'string' || typeof chunk.fill === 'function' || isUint8Array(chunk)) {
-        // noop
-      } else {
-        // throw ERR_INVALID_ARG_TYPE
-        return _write.call(this, chunk, encoding, callback)
-      }
-
-      if (!callback && typeof encoding === 'function') {
-        callback = encoding
-        encoding = undefined
-      }
-
-      if (typeof callback !== 'function') {
-        callback = noop
-      }
-
       if (res.destroyed || res.finished || ended) {
         // HACK: node doesn't expose internal errors,
         // we need to fake response to throw underlying errors type
@@ -149,10 +128,6 @@ function compression (options) {
         }
       }
 
-      if (typeof callback !== 'function') {
-        callback = noop
-      }
-
       if (this.destroyed || this.finished || ended) {
         this.finished = ended
         // throw ERR_STREAM_WRITE_AFTER_END or ERR_STREAM_ALREADY_FINISHED
@@ -375,14 +350,3 @@ function toBuffer (chunk, encoding) {
     ? chunk
     : Buffer.from(chunk, encoding)
 }
-
-/**
- * Checks if the given argument is an instance of Uint8Array.
- *
- * @param {*} arg - The value to check.
- * @returns {boolean} Returns `true` if the argument is an instance of Uint8Array, otherwise `false`.
- * @private
- */
-function isUint8Array (arg) {
-  return arg && arg instanceof Uint8Array
-}

test/compression.js

@@ -101,7 +101,7 @@ describe('compression()', function () {
         try {
           res.write(1)
         } catch (err) {
-          assert.ok(err.toString().indexOf('TypeError') > -1 || err.code === 'ERR_INVALID_ARG_TYPE')
+          assert.ok(err.code === 'ERR_INVALID_ARG_TYPE')
           res.flush()
           res.end()
         }
@@ -119,7 +119,7 @@ describe('compression()', function () {
         try {
           res.write({})
         } catch (err) {
-          assert.ok(err.toString().indexOf('TypeError') > -1 || err.code === 'ERR_INVALID_ARG_TYPE')
+          assert.ok(err.code === 'ERR_INVALID_ARG_TYPE')
           res.flush()
           res.end()
         }
@@ -131,13 +131,13 @@ describe('compression()', function () {
         .expect(200, done)
     })
 
-    it('res.write(null) should fire ERR_INVALID_ARG_TYPE or ERR_STREAM_NULL_VALUES', function (done) {
+    it('res.write(null) should fire ERR_STREAM_NULL_VALUES', function (done) {
       var server = createServer({ threshold: 0 }, function (req, res) {
         res.setHeader('Content-Type', 'text/plain')
         try {
           res.write(null)
         } catch (err) {
-          assert.ok(err.toString().indexOf('TypeError') > -1 || err.code === 'ERR_INVALID_ARG_TYPE' || err.code === 'ERR_STREAM_NULL_VALUES')
+          assert.ok(err.code === 'ERR_STREAM_NULL_VALUES')
           res.flush()
           res.end()
         }
@@ -194,7 +194,7 @@ describe('compression()', function () {
   it('res.write() should call callback with error after end', function (done) {
     var onErrorCalled = false
     var onError = function (err) {
-      assert.ok(err.toString().indexOf('write after end') > -1 || err.code === 'ERR_STREAM_WRITE_AFTER_END')
+      assert.ok(err.code === 'ERR_STREAM_WRITE_AFTER_END')
       onErrorCalled = true
     }