Some API Optimizations (#23)

* Switch order of precompute and trustedSetup init arguments for comfortability

* Set precompute to 0 (faster initialization)

Author: holgerd77

README.md

@@ -35,7 +35,7 @@ The `loadKZG()` function returns an object that implements the KZG interface wit
 
 #### `loadTrustedSetup(trustedSetup?, precompute?)`
 ```ts
-loadTrustedSetup(trustedSetup: TrustedSetup = mainnetTrustedSetup, precompute: number = 8): number
+loadTrustedSetup(trustedSetup: TrustedSetup = mainnetTrustedSetup, precompute: number = 0): number
 ```
 Loads a trusted setup for KZG operations. Returns 0 on success, non-zero on failure.
 

src/index.ts

@@ -29,7 +29,7 @@ const BYTES_PER_CELL = 2048
  *
  * @returns object - the KZG methods required for all 4844 related operations
  */
-export const loadKZG = async (trustedSetup: TrustedSetup = mainnetTrustedSetup, precompute: number = 8) => {
+export const loadKZG = async (precompute: number = 0, trustedSetup: TrustedSetup = mainnetTrustedSetup) => {
     // In Node.js environment, preload the WASM binary to avoid path resolution issues
     let wasmBinary = await loadWasmModule();
 
@@ -55,7 +55,7 @@ export const loadKZG = async (trustedSetup: TrustedSetup = mainnetTrustedSetup,
      * @param trustedSetup - an optional trusted setup parameter provided by the user
      * @returns 0 if loaded successfully or non zero otherwise
      */
-    const loadTrustedSetup = (trustedSetup: TrustedSetup = mainnetTrustedSetup, precompute: number = 8) => {
+    const loadTrustedSetup = (precompute: number = 0, trustedSetup: TrustedSetup = mainnetTrustedSetup) => {
         if(trustedSetup.g1_monomial.length != 48 * 4096 * 2) {
             throw new Error(`trusted setup g1_monomial must be 48 * 4096  bytes long, not ${trustedSetup.g1_monomial.length}`)
         }
@@ -293,7 +293,7 @@ export const loadKZG = async (trustedSetup: TrustedSetup = mainnetTrustedSetup,
         return res === 'true'
     }
 
-    const loadResult = loadTrustedSetup(trustedSetup, precompute);
+    const loadResult = loadTrustedSetup(precompute, trustedSetup);
     if (loadResult !== 0) {
         throw new Error(`Failed to load trusted setup, error code: ${loadResult}`);
     }

test/index.spec.ts

@@ -10,7 +10,7 @@ const BYTES_PER_CELL = 2048
 const BYTES_PER_G1 = 48
 
 describe('kzg initialization', () => {
-  let kzg: any
+  let kzg: Awaited<ReturnType<typeof loadKZG>>
   beforeAll(async () => {
     kzg = await loadKZG()
   })
@@ -22,7 +22,7 @@ describe('kzg initialization', () => {
 
   it('should throw when invalid trusted setup is provided', () => {
     assert.throws(() => {
-      kzg.loadTrustedSetup({ g1_monomial: 'x12',  g1_lagrange: 'bad coordinates', g2_monomial: 'x12'})
+      kzg.loadTrustedSetup(0, { g1_monomial: 'x12',  g1_lagrange: 'bad coordinates', g2_monomial: 'x12'})
     })
   })
 })