-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix hreflang tags to only include translated locales #16790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
97a94c8 to
367df59
Compare
58615d0 to
904a760
Compare
0a6b18e to
79e067e
Compare
|
Detected a bug. We are missing the following pages from the sitemap:
These pages don’t use a namespace for translations, so they aren’t listed in the translation registry. We’ll need a different approach to discover intl pages. Instead of pulling them from the registry, I’ll switch to detecting them by scanning the filesystem. |

Built on top of #16804
Description
Fixes hreflang tags to only include translated locales.
High-level changes
index, followmetatag for untranslated pagesImplementation details
Hreflang fix in
getMetadata()Refactor
src/lib/utils/translations.tsUnified translation registry (
src/lib/i18n/translationRegistry.ts)getTranslatedLocales()to check translation status for both MD and intl pagesSitemap refactor (
app/sitemap.ts)next-sitemapplugin to use a the builtinsitemap.tsfilegetAllPagesWithTranslations()from translation registry