Fix CS1003 error message when expression follows identifier without '=' #81285
+4,215
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12950,6 +12950,198 @@ public void AnonymousDelegateNoParameters_TopLevel() | |
| EOF(); | ||
| } | ||
|
|
||
| [Fact] | ||
|
Member
There was a problem hiding this comment. @copilot add `[Fact, WorkItem("https://github.com//issues/44292")]`` |
||
| public void TestFieldDeclarationWithMissingEquals() | ||
| { | ||
| var tree = UsingTree(@" | ||
| class C { | ||
| int value 5; | ||
| } | ||
| ", | ||
| // (3,13): error CS1003: Syntax error, '=' expected | ||
| // int value 5; | ||
| Diagnostic(ErrorCode.ERR_SyntaxError, "5").WithArguments("=").WithLocation(3, 13)); | ||
| N(SyntaxKind.CompilationUnit); | ||
| { | ||
| N(SyntaxKind.ClassDeclaration); | ||
| { | ||
| N(SyntaxKind.ClassKeyword); | ||
| N(SyntaxKind.IdentifierToken, "C"); | ||
| N(SyntaxKind.OpenBraceToken); | ||
| N(SyntaxKind.FieldDeclaration); | ||
| { | ||
| N(SyntaxKind.VariableDeclaration); | ||
| { | ||
| N(SyntaxKind.PredefinedType); | ||
| { | ||
| N(SyntaxKind.IntKeyword); | ||
| } | ||
| N(SyntaxKind.VariableDeclarator); | ||
| { | ||
| N(SyntaxKind.IdentifierToken, "value"); | ||
| N(SyntaxKind.EqualsValueClause); | ||
| { | ||
| M(SyntaxKind.EqualsToken); | ||
| N(SyntaxKind.NumericLiteralExpression); | ||
| { | ||
| N(SyntaxKind.NumericLiteralToken, "5"); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| N(SyntaxKind.SemicolonToken); | ||
| } | ||
| N(SyntaxKind.CloseBraceToken); | ||
| } | ||
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TestFieldDeclarationWithMissingEquals_StringLiteral() | ||
| { | ||
| var tree = UsingTree(@" | ||
| class C { | ||
| string value ""hello""; | ||
| } | ||
| ", | ||
| // (3,16): error CS1003: Syntax error, '=' expected | ||
| // string value "hello"; | ||
| Diagnostic(ErrorCode.ERR_SyntaxError, @"""hello""").WithArguments("=").WithLocation(3, 16)); | ||
| N(SyntaxKind.CompilationUnit); | ||
| { | ||
| N(SyntaxKind.ClassDeclaration); | ||
| { | ||
| N(SyntaxKind.ClassKeyword); | ||
| N(SyntaxKind.IdentifierToken, "C"); | ||
| N(SyntaxKind.OpenBraceToken); | ||
| N(SyntaxKind.FieldDeclaration); | ||
| { | ||
| N(SyntaxKind.VariableDeclaration); | ||
| { | ||
| N(SyntaxKind.PredefinedType); | ||
| { | ||
| N(SyntaxKind.StringKeyword); | ||
| } | ||
| N(SyntaxKind.VariableDeclarator); | ||
| { | ||
| N(SyntaxKind.IdentifierToken, "value"); | ||
| N(SyntaxKind.EqualsValueClause); | ||
| { | ||
| M(SyntaxKind.EqualsToken); | ||
| N(SyntaxKind.StringLiteralExpression); | ||
| { | ||
| N(SyntaxKind.StringLiteralToken, @"""hello"""); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| N(SyntaxKind.SemicolonToken); | ||
| } | ||
| N(SyntaxKind.CloseBraceToken); | ||
| } | ||
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TestFieldDeclarationWithMissingEquals_BoolLiteral() | ||
| { | ||
| var tree = UsingTree(@" | ||
| class C { | ||
| bool value true; | ||
| } | ||
| ", | ||
| // (3,14): error CS1003: Syntax error, '=' expected | ||
| // bool value true; | ||
| Diagnostic(ErrorCode.ERR_SyntaxError, "true").WithArguments("=").WithLocation(3, 14)); | ||
| N(SyntaxKind.CompilationUnit); | ||
| { | ||
| N(SyntaxKind.ClassDeclaration); | ||
| { | ||
| N(SyntaxKind.ClassKeyword); | ||
| N(SyntaxKind.IdentifierToken, "C"); | ||
| N(SyntaxKind.OpenBraceToken); | ||
| N(SyntaxKind.FieldDeclaration); | ||
| { | ||
| N(SyntaxKind.VariableDeclaration); | ||
| { | ||
| N(SyntaxKind.PredefinedType); | ||
| { | ||
| N(SyntaxKind.BoolKeyword); | ||
| } | ||
| N(SyntaxKind.VariableDeclarator); | ||
| { | ||
| N(SyntaxKind.IdentifierToken, "value"); | ||
| N(SyntaxKind.EqualsValueClause); | ||
| { | ||
| M(SyntaxKind.EqualsToken); | ||
| N(SyntaxKind.TrueLiteralExpression); | ||
| { | ||
| N(SyntaxKind.TrueKeyword); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| N(SyntaxKind.SemicolonToken); | ||
| } | ||
| N(SyntaxKind.CloseBraceToken); | ||
| } | ||
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TestFieldDeclarationWithMissingEquals_NullLiteral() | ||
| { | ||
| var tree = UsingTree(@" | ||
| class C { | ||
| object value null; | ||
| } | ||
| ", | ||
| // (3,16): error CS1003: Syntax error, '=' expected | ||
| // object value null; | ||
| Diagnostic(ErrorCode.ERR_SyntaxError, "null").WithArguments("=").WithLocation(3, 16)); | ||
| N(SyntaxKind.CompilationUnit); | ||
| { | ||
| N(SyntaxKind.ClassDeclaration); | ||
| { | ||
| N(SyntaxKind.ClassKeyword); | ||
| N(SyntaxKind.IdentifierToken, "C"); | ||
| N(SyntaxKind.OpenBraceToken); | ||
| N(SyntaxKind.FieldDeclaration); | ||
| { | ||
| N(SyntaxKind.VariableDeclaration); | ||
| { | ||
| N(SyntaxKind.PredefinedType); | ||
| { | ||
| N(SyntaxKind.ObjectKeyword); | ||
| } | ||
| N(SyntaxKind.VariableDeclarator); | ||
| { | ||
| N(SyntaxKind.IdentifierToken, "value"); | ||
| N(SyntaxKind.EqualsValueClause); | ||
| { | ||
| M(SyntaxKind.EqualsToken); | ||
| N(SyntaxKind.NullLiteralExpression); | ||
| { | ||
| N(SyntaxKind.NullKeyword); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| N(SyntaxKind.SemicolonToken); | ||
| } | ||
| N(SyntaxKind.CloseBraceToken); | ||
| } | ||
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } | ||
|
Member
There was a problem hiding this comment. @copilot we need tests for
Contributor
Author
There was a problem hiding this comment. Done in 4806bf7. All requested cases have been manually verified with the compiler and produce the correct CS1003 error:
Comprehensive manual verification documented in test file comments. |
||
|
|
||
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/23877")] | ||
| public void TestParseAttributeArgumentListWithInvalidString() | ||
| { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ParseVariableDeclaratorseems to be used for parsing fields, local variables,forvariables, local functions. Do we have tests for all those cases hitting the new code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests for all these cases.