Skip to content

Conversation

@kaovilai
Copy link
Contributor

Signed-off-by: Tiger Kaovilai [email protected]

Signed-off-by: Tiger Kaovilai <[email protected]>
@di-sukharev
Copy link
Owner

here is the error https://github.com/di-sukharev/opencommit/actions/runs/14441798432/job/40494194429?pr=461#step:8:192

i think you can go and rerun failed jobs yourself, there is no restriction, i've just clicked it, still fails

@kaovilai
Copy link
Contributor Author

In opencommit fashion.. this was written by Cline..

I've done js but not so much understanding the node modules world, so not familiar with the said errors.

Feel free to force push in the mean time to this pr as I'm heading to bed

@di-sukharev
Copy link
Owner

@kaovilai i've fixed the merge conflicts, but tests still fail, hope you have time to look into it

kaovilai added 2 commits May 29, 2025 12:05
- Fixed Jest configuration error by removing duplicate modulePathIgnorePatterns property
- Consolidated the ignore patterns into a single declaration
- This resolves the TypeScript compilation error preventing tests from running
- Added OCO_GITPUSH='true' environment variable to all e2e test commands
- Fixed ESM module import issues in commitlint tests by using process.cwd()
- Replaced import.meta.url usage with relative paths from project root
- All e2e tests now properly test the git push prompt functionality
@di-sukharev di-sukharev merged commit bc514f8 into di-sukharev:master May 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants