Commit 21abc7f
committed
cue/ast: remove Node.Comments and Node.AddComment
And deprecate the methods which get promoted into every Node
implementation, which is what many users end up actually using.
These Node methods were deprecated back in late 2019 in
https://cue-review.googlesource.com/c/cue/+/3221,
more than six years ago, so at this point they can be removed.
The corresponding methods in the comments type, which are promoted
into every Node implementation via embedding, were not deprecated yet.
As such, removing them outright doesn't seem fair to users.
Deprecate them now, and leave a note to remove in the future.
Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I321ae429e91e004f51a0824e98088cf1cc28e11e
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1224693
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Roger Peppe <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>1 parent 3d8f535 commit 21abc7f
1 file changed
+8
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 58 | | |
64 | 59 | | |
65 | 60 | | |
| |||
147 | 142 | | |
148 | 143 | | |
149 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
| 158 | + | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
| |||
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
| 176 | + | |
174 | 177 | | |
175 | 178 | | |
176 | 179 | | |
| |||
0 commit comments