Skip to content

Commit 487ef74

Browse files
seefeldbclaude
andcommitted
fix(tests): use pull() in pattern harness for pull mode compatibility
In pull mode, .get() returns cached values without triggering computation of dirty dependencies. Changed the pattern harness to use .pull() which properly establishes an effect and waits for the scheduler to compute all transitive dependencies. This fixes 27/28 failing generated-patterns integration tests. One test (counter-when-unless-operators) still fails due to a deeper issue with nested lift computations through references. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent cfb0fad commit 487ef74

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/generated-patterns/integration/pattern-harness.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ export async function runPatternScenario(scenario: PatternIntegrationScenario) {
117117
(cell, segment) => cell.key(segment),
118118
result,
119119
);
120-
const actual = targetCell.get();
120+
// Use pull() in pull mode to ensure all dependencies are computed
121+
const actual = await targetCell.pull();
121122
expect(actual, `${name}:${stepIndex}:${assertion.path}`)
122123
.toEqual(assertion.value);
123124
}

0 commit comments

Comments
 (0)